2011-07-04 10:40:11

by Nick Kossifidis

Subject: Re: [ath5k-devel] [PATCH 4/8] ath5k: initialize common->clockrate

2011/7/4 Felix Fietkau <[email protected]>:
> Fixes a division by zero when setting distance before activating the
> device for the first time.
>
> Signed-off-by: Felix Fietkau <[email protected]>
> ---
>  drivers/net/wireless/ath/ath5k/base.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath5k/base.c b/drivers/net/wireless/ath/ath5k/base.c
> index a6623dd..a413aa7 100644
> --- a/drivers/net/wireless/ath/ath5k/base.c
> +++ b/drivers/net/wireless/ath/ath5k/base.c
> @@ -2422,6 +2422,7 @@ ath5k_init_softc(struct ath5k_softc *sc, const struct ath_bus_ops *bus_ops)
>        common->ah = sc->ah;
>        common->hw = hw;
>        common->priv = sc;
> +       common->clockrate = 40;
>
>        /*
>         * Cache line size is used to size and align various
> --
> 1.7.3.2
>

We better set this to 44 for g (according to docs core frequency is 44MHz for g)


--
GPG ID: 0xD21DB2DB
As you read this post global entropy rises. Have Fun ;-)
Nick

2011-07-04 10:49:02

by Nick Kossifidis

Subject: Re: [ath5k-devel] [PATCH 4/8] ath5k: initialize common->clockrate

2011/7/4 Felix Fietkau <[email protected]>:
> On 2011-07-04 5:40 PM, Nick Kossifidis wrote:
>>
>> 2011/7/4 Felix Fietkau<[email protected]>:
>>>
>>>  Fixes a division by zero when setting distance before activating the
>>>  device for the first time.
>>>
>>>  Signed-off-by: Felix Fietkau<[email protected]>
>>>  ---
>>>   drivers/net/wireless/ath/ath5k/base.c |    1 +
>>>   1 files changed, 1 insertions(+), 0 deletions(-)
>>>
>>>  diff --git a/drivers/net/wireless/ath/ath5k/base.c
>>> b/drivers/net/wireless/ath/ath5k/base.c
>>>  index a6623dd..a413aa7 100644
>>>  --- a/drivers/net/wireless/ath/ath5k/base.c
>>>  +++ b/drivers/net/wireless/ath/ath5k/base.c
>>>  @@ -2422,6 +2422,7 @@ ath5k_init_softc(struct ath5k_softc *sc, const
>>> struct ath_bus_ops *bus_ops)
>>>         common->ah = sc->ah;
>>>         common->hw = hw;
>>>         common->priv = sc;
>>>  +       common->clockrate = 40;
>>>
>>>         /*
>>>          * Cache line size is used to size and align various
>>>  --
>>>  1.7.3.2
>>>
>>
>> We better set this to 44 for g (according to docs core frequency is 44MHz
>> for g)
>
> It shouldn't make a difference, since the first hardware reset will reload
> all the settings anyway.
>
> - Felix
>

O.K.

Acked-by: Nick Kossifidis <[email protected]>

--
GPG ID: 0xD21DB2DB
As you read this post global entropy rises. Have Fun ;-)
Nick

2011-07-04 10:45:13

by Felix Fietkau

Subject: Re: [ath5k-devel] [PATCH 4/8] ath5k: initialize common->clockrate

On 2011-07-04 5:40 PM, Nick Kossifidis wrote:
> 2011/7/4 Felix Fietkau<[email protected]>:
>> Fixes a division by zero when setting distance before activating the
>> device for the first time.
>>
>> Signed-off-by: Felix Fietkau<[email protected]>
>> ---
>> drivers/net/wireless/ath/ath5k/base.c | 1 +
>> 1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/net/wireless/ath/ath5k/base.c b/drivers/net/wireless/ath/ath5k/base.c
>> index a6623dd..a413aa7 100644
>> --- a/drivers/net/wireless/ath/ath5k/base.c
>> +++ b/drivers/net/wireless/ath/ath5k/base.c
>> @@ -2422,6 +2422,7 @@ ath5k_init_softc(struct ath5k_softc *sc, const struct ath_bus_ops *bus_ops)
>> common->ah = sc->ah;
>> common->hw = hw;
>> common->priv = sc;
>> + common->clockrate = 40;
>>
>> /*
>> * Cache line size is used to size and align various
>> --
>> 1.7.3.2
>>
>
> We better set this to 44 for g (according to docs core frequency is 44MHz for g)
It shouldn't make a difference, since the first hardware reset will
reload all the settings anyway.

- Felix