2013-01-10 16:04:50

by Sujith Manoharan

Subject: [PATCH] Revert "ath9k_hw: Fix calibration for AR9340"

From: Sujith Manoharan <[email protected]>

This reverts commit 03c2dc73581ad4ae54f1ccfc1463929b16b8b736.

The change for AR9340 breaks TP-Link TL-WDR4300, we can re-submit this
change once the HW differences are identified and appropriate code
changes have been made.

Reported-by: Felix Fietkau <[email protected]>
Signed-off-by: Sujith Manoharan <[email protected]>
---
drivers/net/wireless/ath/ath9k/ar9003_calib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/ath/ath9k/ar9003_calib.c b/drivers/net/wireless/ath/ath9k/ar9003_calib.c
index 9221f32..4caa80b 100644
--- a/drivers/net/wireless/ath/ath9k/ar9003_calib.c
+++ b/drivers/net/wireless/ath/ath9k/ar9003_calib.c
@@ -319,7 +319,7 @@ static void ar9003_hw_init_cal_settings(struct ath_hw *ah)

if (AR_SREV_9300_20_OR_LATER(ah)) {
ah->enabled_cals |= TX_IQ_CAL;
- if (AR_SREV_9485_OR_LATER(ah) && !AR_SREV_9340(ah))
+ if (AR_SREV_9485_OR_LATER(ah))
ah->enabled_cals |= TX_IQ_ON_AGC_CAL;
}

--
1.8.1

2013-01-10 18:38:29

by Felix Fietkau

Subject: Re: [PATCH] Revert "ath9k_hw: Fix calibration for AR9340"

On 2013-01-10 5:03 PM, Sujith Manoharan wrote:
> From: Sujith Manoharan <[email protected]>
>
> This reverts commit 03c2dc73581ad4ae54f1ccfc1463929b16b8b736.
>
> The change for AR9340 breaks TP-Link TL-WDR4300, we can re-submit this
> change once the HW differences are identified and appropriate code
> changes have been made.
>
> Reported-by: Felix Fietkau <[email protected]>
> Signed-off-by: Sujith Manoharan <[email protected]>
No need to apply this, the root cause has been found and I'll send a fix
for it.

- Felix