2013-01-26 21:16:57

by Johannes Berg

Subject: [PATCH] cfg80211: add SME state to warning in __cfg80211_mlme_disassoc

From: Johannes Berg <[email protected]>

The warning here occasionally triggers but we haven't
found the cause yet. It's a valid warning since if it
triggers the SME state got confused, so add the SME
state to it to help narrow it down in the future.

Signed-off-by: Johannes Berg <[email protected]>
---
net/wireless/mlme.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/wireless/mlme.c b/net/wireless/mlme.c
index 461e692..fee9bf7 100644
--- a/net/wireless/mlme.c
+++ b/net/wireless/mlme.c
@@ -514,7 +514,7 @@ static int __cfg80211_mlme_disassoc(struct cfg80211_registered_device *rdev,
if (wdev->sme_state != CFG80211_SME_CONNECTED)
return -ENOTCONN;

- if (WARN_ON(!wdev->current_bss))
+ if (WARN(!wdev->current_bss, "sme_state=%d\n", wdev->sme_state))
return -ENOTCONN;

memset(&req, 0, sizeof(req));
--
1.8.0

2013-01-29 10:53:08

by Johannes Berg

Subject: Re: [PATCH] cfg80211: add SME state to warning in __cfg80211_mlme_disassoc

On Sat, 2013-01-26 at 22:17 +0100, Johannes Berg wrote:
> From: Johannes Berg <[email protected]>
>
> The warning here occasionally triggers but we haven't
> found the cause yet. It's a valid warning since if it
> triggers the SME state got confused, so add the SME
> state to it to help narrow it down in the future.

Applied.

johannes