2013-02-23 10:47:59

by Walter Goldens

[permalink] [raw]
Subject: compat-wireless/drivers - slew of warnings and issues (older kernel)

A recent (stable) compat-wireless/drivers compilation exhibited a great deal of warnings on an older kernel (2.6.24  to 2.6.30 I think). Is 2.6.24 still supported?

Also, there was an issue with 50-compat_firmware.rules. Ubuntu 8.04 looks for it at /lib/udev/rules.d/ which gave me severe problems with firmware loading and system freezes. I had to copy/symlink 50-compat_firmware.rules from /lib/udev/rules.d/ to /etc/udev/rules.d/.

Warning log (partial). It compiles, but warnings galore. Is anyone up for backporting?


  CC [M]  /drivers/net/wireless/rt2x00/rt2x00dev.o
/include/net/cfg80211.h: In function ‘wiphy_name’:
/include/net/cfg80211.h:2676: warning: passing argument 1 of ‘dev_name’ discards qualifiers from pointer target type
  CC [M]  /drivers/net/wireless/rt2x00/rt2x00mac.o
/include/net/cfg80211.h: In function ‘wiphy_name’:
/include/net/cfg80211.h:2676: warning: passing argument 1 of ‘dev_name’ discards qualifiers from pointer target type
  CC [M]  /drivers/net/wireless/rt2x00/rt2x00config.o
  CC [M]  /drivers/net/wireless/rt2x00/rt2x00queue.o
/include/net/cfg80211.h: In function ‘wiphy_name’:
/include/net/cfg80211.h:2676: warning: passing argument 1 of ‘dev_name’ discards qualifiers from pointer target type
  CC [M]  /drivers/net/wireless/rt2x00/rt2x00link.o
  CC [M]  /drivers/net/wireless/rt2x00/rt2x00crypto.o
  CC [M]  /drivers/net/wireless/rt2x00/rt2x00firmware.o
/include/net/cfg80211.h: In function ‘wiphy_name’:
/include/net/cfg80211.h:2676: warning: passing argument 1 of ‘dev_name’ discards qualifiers from pointer target type
  LD [M]  /drivers/net/wireless/rt2x00/rt2x00lib.o
  CC [M]  /drivers/net/wireless/rt2x00/rt2x00pci.o
/include/net/cfg80211.h: In function ‘wiphy_name’:
/include/net/cfg80211.h:2676: warning: passing argument 1 of ‘dev_name’ discards qualifiers from pointer target type
  CC [M]  /drivers/net/wireless/rt2x00/rt2x00usb.o
/include/net/cfg80211.h: In function ‘wiphy_name’:
/include/net/cfg80211.h:2676: warning: passing argument 1 of ‘dev_name’ discards qualifiers from pointer target type
  CC [M]  /drivers/net/wireless/rt2x00/rt2800lib.o
/include/net/cfg80211.h: In function ‘wiphy_name’:
/include/net/cfg80211.h:2676: warning: passing argument 1 of ‘dev_name’ discards qualifiers from pointer target type
/drivers/net/wireless/rt2x00/rt2800lib.c: In function ‘rt2800_config_erp’:
/drivers/net/wireless/rt2x00/rt2800lib.c:1383: warning: ‘gf40_mode’ may be used uninitialized in this function
/drivers/net/wireless/rt2x00/rt2800lib.c:1383: note: ‘gf40_mode’ was declared here
/drivers/net/wireless/rt2x00/rt2800lib.c:1383: warning: ‘gf20_mode’ may be used uninitialized in this function
/drivers/net/wireless/rt2x00/rt2800lib.c:1383: note: ‘gf20_mode’ was declared here
/drivers/net/wireless/rt2x00/rt2800lib.c:1383: warning: ‘mm40_mode’ may be used uninitialized in this function
/drivers/net/wireless/rt2x00/rt2800lib.c:1383: note: ‘mm40_mode’ was declared here
/drivers/net/wireless/rt2x00/rt2800lib.c:1383: warning: ‘mm20_mode’ may be used uninitialized in this function
/drivers/net/wireless/rt2x00/rt2800lib.c:1383: note: ‘mm20_mode’ was declared here
  CC [M]  /drivers/net/wireless/rt2x00/rt2400pci.o
/include/net/cfg80211.h: In function ‘wiphy_name’:
/include/net/cfg80211.h:2676: warning: passing argument 1 of ‘dev_name’ discards qualifiers from pointer target type
  CC [M]  /drivers/net/wireless/rt2x00/rt2500pci.o
/include/net/cfg80211.h: In function ‘wiphy_name’:
/include/net/cfg80211.h:2676: warning: passing argument 1 of ‘dev_name’ discards qualifiers from pointer target type
  CC [M]  /drivers/net/wireless/rt2x00/rt61pci.o
/drivers/net/wireless/rt2x00/rt61pci.c: In function ‘__check_nohwcrypt’:
/drivers/net/wireless/rt2x00/rt61pci.c:45: warning: return from incompatible pointer type
/include/net/cfg80211.h: In function ‘wiphy_name’:
/include/net/cfg80211.h:2676: warning: passing argument 1 of ‘dev_name’ discards qualifiers from pointer target type
  CC [M]  /drivers/net/wireless/rt2x00/rt2800pci.o
/drivers/net/wireless/rt2x00/rt2800pci.c: In function ‘__check_nohwcrypt’:
/drivers/net/wireless/rt2x00/rt2800pci.c:54: warning: return from incompatible pointer type
include/asm/io_32.h: In function ‘memcpy_fromio’:
include/asm/io_32.h:211: warning: passing argument 2 of ‘__memcpy’ discards qualifiers from pointer target type
/include/net/cfg80211.h: In function ‘wiphy_name’:
/include/net/cfg80211.h:2676: warning: passing argument 1 of ‘dev_name’ discards qualifiers from pointer target type
  CC [M]  /drivers/net/wireless/rt2x00/rt2500usb.o
/drivers/net/wireless/rt2x00/rt2500usb.c: In function ‘__check_nohwcrypt’:
/drivers/net/wireless/rt2x00/rt2500usb.c:43: warning: return from incompatible pointer type
/include/net/cfg80211.h: In function ‘wiphy_name’:
/include/net/cfg80211.h:2676: warning: passing argument 1 of ‘dev_name’ discards qualifiers from pointer target type
  CC [M]  /drivers/net/wireless/rt2x00/rt73usb.o
/drivers/net/wireless/rt2x00/rt73usb.c: In function ‘__check_nohwcrypt’:
/drivers/net/wireless/rt2x00/rt73usb.c:44: warning: return from incompatible pointer type
/include/net/cfg80211.h: In function ‘wiphy_name’:
/include/net/cfg80211.h:2676: warning: passing argument 1 of ‘dev_name’ discards qualifiers from pointer target type
  CC [M]  /drivers/net/wireless/rt2x00/rt2800usb.o
/drivers/net/wireless/rt2x00/rt2800usb.c: In function ‘__check_nohwcrypt’:
/drivers/net/wireless/rt2x00/rt2800usb.c:49: warning: return from incompatible pointer type
/include/net/cfg80211.h: In function ‘wiphy_name’:
/include/net/cfg80211.h:2676: warning: passing argument 1 of ‘dev_name’ discards qualifiers from pointer target type
  CC [M]  /drivers/net/wireless/rtl818x/rtl8187/leds.o
/drivers/net/wireless/rtl818x/rtl8187/leds.c: In function ‘rtl8187_register_led’:
/drivers/net/wireless/rtl818x/rtl8187/leds.c:152: warning: assignment discards qualifiers from pointer target type
/include/net/cfg80211.h: In function ‘wiphy_name’:
/include/net/cfg80211.h:2676: warning: passing argument 1 of ‘dev_name’ discards qualifiers from pointer target type
  CC [M]  /net/mac80211/main.o
/include/net/cfg80211.h: In function ‘wiphy_name’:
/include/net/cfg80211.h:2676: warning: passing argument 1 of ‘dev_name’ discards qualifiers from pointer target type
  CC [M]  /net/mac80211/ht.o
/net/mac80211/ht.c: In function ‘ieee80211_ht_cap_ie_to_sta_ht_cap’:
/net/mac80211/ht.c:105: warning: ‘smps_mode’ may be used uninitialized in this function
  CC [M]  /net/mac80211/iface.o
/include/net/cfg80211.h: In function ‘wiphy_name’:
/include/net/cfg80211.h:2676: warning: passing argument 1 of ‘dev_name’ discards qualifiers from pointer target type
  CC [M]  /net/mac80211/cfg.o
/include/net/cfg80211.h: In function ‘wiphy_name’:
/include/net/cfg80211.h:2676: warning: passing argument 1 of ‘dev_name’ discards qualifiers from pointer target type
  CC [M]  /net/mac80211/rx.o
  CC [M]  /net/mac80211/spectmgmt.o
  CC [M]  /net/mac80211/tx.o
/net/mac80211/tx.c: In function ‘ieee80211_subif_start_xmit’:
/net/mac80211/tx.c:1778: warning: ‘chanctx_conf’ may be used uninitialized in this function
  CC [M]  /net/mac80211/mlme.o
/net/mac80211/mlme.c: In function ‘ieee80211_prep_connection’:
/net/mac80211/mlme.c:3780: warning: ‘have_higher_than_11mbit’ may be used uninitialized in this function
  CC [M]  /net/mac80211/led.o
/include/net/cfg80211.h: In function ‘wiphy_name’:
/include/net/cfg80211.h:2676: warning: passing argument 1 of ‘dev_name’ discards qualifiers from pointer target type
  CC [M]  /net/mac80211/debugfs.o
/include/net/cfg80211.h: In function ‘wiphy_name’:
/include/net/cfg80211.h:2676: warning: passing argument 1 of ‘dev_name’ discards qualifiers from pointer target type
  CC [M]  /net/mac80211/debugfs_sta.o
  CC [M]  /net/mac80211/debugfs_netdev.o
/net/mac80211/debugfs_netdev.c: In function ‘ieee80211_if_fmt_tsf’:
/net/mac80211/debugfs_netdev.c:415: warning: passing argument 2 of ‘drv_get_tsf’ discards qualifiers from pointer target type
  CC [M]  /net/mac80211/debugfs_key.o
/net/mac80211/debugfs_key.c:37:1: warning: "KEY_FILE" redefined
In file included from /include/linux/compat-2.6.28.h:15,
                 from /include/linux/compat-2.6.h:51,
                 from <command-line>:0:
include/linux/input.h:267:1: warning: this is the location of the previous definition
  CC [M]  /net/wireless/core.o
/net/wireless/core.c: In function ‘__check_cfg80211_disable_40mhz_24ghz’:
/net/wireless/core.c:53: warning: return from incompatible pointer type
/include/net/cfg80211.h: In function ‘wiphy_name’:
/include/net/cfg80211.h:2676: warning: passing argument 1 of ‘dev_name’ discards qualifiers from pointer target type
  CC [M]  /net/wireless/nl80211.o
/net/wireless/nl80211.c: In function ‘nl80211_parse_mesh_config’:
/net/wireless/nl80211.c:4383: warning: comparison is always false due to limited range of data type
/net/wireless/nl80211.c:4386: warning: comparison is always false due to limited range of data type
/net/wireless/nl80211.c:4389: warning: comparison is always false due to limited range of data type
/net/wireless/nl80211.c:4391: warning: comparison is always false due to limited range of data type
/net/wireless/nl80211.c:4394: warning: comparison is always false due to limited range of data type
/net/wireless/nl80211.c:4401: warning: comparison is always false due to limited range of data type
/net/wireless/nl80211.c:4401: warning: comparison is always false due to limited range of data type
/net/wireless/nl80211.c:4407: warning: comparison is always false due to limited range of data type
/net/wireless/nl80211.c:4414: warning: comparison is always false due to limited range of data type
/net/wireless/nl80211.c:4418: warning: comparison is always false due to limited range of data type
/net/wireless/nl80211.c:4422: warning: comparison is always false due to limited range of data type
/net/wireless/nl80211.c:4427: warning: comparison is always false due to limited range of data type
/net/wireless/nl80211.c:4430: warning: comparison is always false due to limited range of data type
/net/wireless/nl80211.c:4433: warning: comparison is always false due to limited range of data type
/net/wireless/nl80211.c:4437: warning: comparison is always false due to limited range of data type
/net/wireless/nl80211.c:4443: warning: comparison is always false due to limited range of data type
/net/wireless/nl80211.c:4450: warning: comparison is always false due to limited range of data type
/net/wireless/nl80211.c:4453: warning: comparison is always false due to limited range of data type
/net/wireless/nl80211.c:4463: warning: comparison is always false due to limited range of data type
/net/wireless/nl80211.c:4463: warning: comparison is always false due to limited range of data type
/include/net/cfg80211.h: In function ‘wiphy_name’:
/include/net/cfg80211.h:2676: warning: passing argument 1 of ‘dev_name’ discards qualifiers from pointer target type
/net/wireless/nl80211.c: In function ‘nl80211_parse_wowlan_tcp’:
/net/wireless/nl80211.c:7416: warning: passing argument 1 of ‘__constant_memcpy’ discards qualifiers from pointer target type
/net/wireless/nl80211.c:7416: warning: passing argument 1 of ‘__memcpy’ discards qualifiers from pointer target type
/net/wireless/nl80211.c:7424: warning: passing argument 1 of ‘__constant_memcpy’ discards qualifiers from pointer target type
/net/wireless/nl80211.c:7424: warning: passing argument 1 of ‘__memcpy’ discards qualifiers from pointer target type
/net/wireless/nl80211.c:7429: warning: passing argument 1 of ‘__constant_memcpy’ discards qualifiers from pointer target type
/net/wireless/nl80211.c:7429: warning: passing argument 1 of ‘__memcpy’ discards qualifiers from pointer target type
/net/wireless/nl80211.c: In function ‘nl80211_pre_doit’:
/net/wireless/nl80211.c:58: warning: ‘wdev_id’ may be used uninitialized in this function
/net/wireless/nl80211.c:58: note: ‘wdev_id’ was declared here
/net/wireless/nl80211.c: In function ‘nl80211_trigger_scan’:
/net/wireless/nl80211.c:4874: warning: passing argument 1 of ‘__constant_memcpy’ discards qualifiers from pointer target type
/net/wireless/nl80211.c:4874: warning: passing argument 1 of ‘__memcpy’ discards qualifiers from pointer target type
/net/wireless/nl80211.c: In function ‘nl80211_start_sched_scan’:
/net/wireless/nl80211.c:5142: warning: passing argument 1 of ‘__constant_memcpy’ discards qualifiers from pointer target type
/net/wireless/nl80211.c:5142: warning: passing argument 1 of ‘__memcpy’ discards qualifiers from pointer target type
  CC [M]  /net/wireless/mlme.o
  CC [M]  /net/wireless/ibss.o
  CC [M]  /net/wireless/sme.o
/net/wireless/sme.c: In function ‘cfg80211_roamed_bss’:
/net/wireless/sme.c:673: warning: passing argument 1 of ‘__constant_memcpy’ discards qualifiers from pointer target type
/net/wireless/sme.c:673: warning: passing argument 1 of ‘__memcpy’ discards qualifiers from pointer target type
/net/wireless/sme.c:676: warning: passing argument 1 of ‘__constant_memcpy’ discards qualifiers from pointer target type
/net/wireless/sme.c:676: warning: passing argument 1 of ‘__memcpy’ discards qualifiers from pointer target type
/net/wireless/sme.c: In function ‘cfg80211_disconnected’:
/net/wireless/sme.c:758: warning: passing argument 1 of ‘__constant_memcpy’ discards qualifiers from pointer target type
/net/wireless/sme.c:758: warning: passing argument 1 of ‘__memcpy’ discards qualifiers from pointer target type
/net/wireless/sme.c: In function ‘cfg80211_connect_result’:
/net/wireless/sme.c:550: warning: passing argument 1 of ‘__constant_memcpy’ discards qualifiers from pointer target type
/net/wireless/sme.c:550: warning: passing argument 1 of ‘__memcpy’ discards qualifiers from pointer target type
/net/wireless/sme.c:555: warning: passing argument 1 of ‘__constant_memcpy’ discards qualifiers from pointer target type
/net/wireless/sme.c:555: warning: passing argument 1 of ‘__memcpy’ discards qualifiers from pointer target type

-- Walter


2013-02-25 10:35:47

by Walter Goldens

[permalink] [raw]
Subject: Re: compat-wireless/drivers - slew of warnings and issues (older kernel)

Hi Hauke

To answer your questions. The compat-drivers I'm quoting is 3.7.6.1-stable and from the daily build tars (2.20.13).
GCC version is 4.2.3

C-D compiles, but as noted with a tonne of warnings. We have several servers with specific purposes running 2.6.24 kernels and I decided to try a C-D on them.
I guess the question now is, do we drop support for c-wireless/drivers for 2.6.24 - 2.6.29(?) and bump the minimum kernel to a 2.6.30?

Walter





----- Original Message -----
From: Hauke Mehrtens <[email protected]>
To: Walter Goldens <[email protected]>
Cc: "[email protected]" <[email protected]>; Luis R. Rodriguez <[email protected]>; "[email protected]" <[email protected]>
Sent: Sunday, February 24, 2013 1:45 PM
Subject: Re: compat-wireless/drivers - slew of warnings and issues (older kernel)

On 02/23/2013 11:41 AM, Walter Goldens wrote:
> A recent (stable) compat-wireless/drivers compilation exhibited a great deal of warnings on an older kernel (2.6.24  to 2.6.30 I think). Is 2.6.24 still supported?

What version of compat-drivers are you using?
What version of gcc are your using?

Some parts of compat-drivers are still compiling against kernel 2.6.24,
but I would not recommend using a so old kernel. I haven't done run time
testes with 2.6.24 for a long time.

> Also, there was an issue with 50-compat_firmware.rules. Ubuntu 8.04 looks for it at /lib/udev/rules.d/ which gave me severe problems with firmware loading and system freezes. I had to copy/symlink 50-compat_firmware.rules from /lib/udev/rules.d/ to /etc/udev/rules.d/.

Could you provide a patch for this, I do not have a ubuntu 8.04
installation any more, this is pretty old.

> Warning log (partial). It compiles, but warnings galore. Is anyone up for backporting?
>
>  CC [M]  /drivers/net/wireless/rt2x00/rt2x00dev.o
> /include/net/cfg80211.h: In function ‘wiphy_name’:
> /include/net/cfg80211.h:2676: warning: passing argument 1 of ‘dev_name’ discards qualifiers from pointer target type

I do not get these warnings when compiling compat-drivers-3.8 against
kernel 2.6.30. There are some other warnings with gcc 4.7 therefor I
used "export KCFLAGS="-Wno-unused-but-set-variable"" with these old
kernels, newer kernel versions already do this in the main Makefile.

Hauke


2013-02-24 11:45:15

by Hauke Mehrtens

[permalink] [raw]
Subject: Re: compat-wireless/drivers - slew of warnings and issues (older kernel)

On 02/23/2013 11:41 AM, Walter Goldens wrote:
> A recent (stable) compat-wireless/drivers compilation exhibited a great deal of warnings on an older kernel (2.6.24 to 2.6.30 I think). Is 2.6.24 still supported?

What version of compat-drivers are you using?
What version of gcc are your using?

Some parts of compat-drivers are still compiling against kernel 2.6.24,
but I would not recommend using a so old kernel. I haven't done run time
testes with 2.6.24 for a long time.

> Also, there was an issue with 50-compat_firmware.rules. Ubuntu 8.04 looks for it at /lib/udev/rules.d/ which gave me severe problems with firmware loading and system freezes. I had to copy/symlink 50-compat_firmware.rules from /lib/udev/rules.d/ to /etc/udev/rules.d/.

Could you provide a patch for this, I do not have a ubuntu 8.04
installation any more, this is pretty old.

> Warning log (partial). It compiles, but warnings galore. Is anyone up for backporting?
>
> CC [M] /drivers/net/wireless/rt2x00/rt2x00dev.o
> /include/net/cfg80211.h: In function ‘wiphy_name’:
> /include/net/cfg80211.h:2676: warning: passing argument 1 of ‘dev_name’ discards qualifiers from pointer target type

I do not get these warnings when compiling compat-drivers-3.8 against
kernel 2.6.30. There are some other warnings with gcc 4.7 therefor I
used "export KCFLAGS="-Wno-unused-but-set-variable"" with these old
kernels, newer kernel versions already do this in the main Makefile.

Hauke