2013-02-18 11:08:50

by Girish Bn

[permalink] [raw]
Subject: patch : mac80211:Multicast patch for linux-2.6.28.1 (wl12xx drivers)

Hi All,

The below patch file is required in order for the multicasting to work properly on Linux kernel below 3.2 for wl12xx drivers
diff -Naur a/net/mac80211/iface.c b/net/mac80211/iface.c
--- a/net/mac80211/iface.c 2012-09-22 22:59:15.000000000 +0530
+++ b/net/mac80211/iface.c 2013-02-07 12:06:03.958268798 +0530
@@ -811,6 +811,9 @@
.ndo_uninit = ieee80211_teardown_sdata,
.ndo_start_xmit = ieee80211_subif_start_xmit,
.ndo_set_rx_mode = ieee80211_set_multicast_list,
+#if (LINUX_VERSION_CODE < KERNEL_VERSION(3,2,0))
+ .ndo_set_multicast_list = ieee80211_set_multicast_list,
+#endif
.ndo_change_mtu = ieee80211_change_mtu,
.ndo_set_mac_address = ieee80211_change_mac,
.ndo_select_queue = ieee80211_netdev_select_queue,

This above patch will disable the multicast filter at the wl1271 hardware

Thanks & Regards,
Girish
L&T IES,
KIADB Industrial Area,
Hebbal-Hootagalli, Mysore - 570 018
Telephone : DID+91-821-2405552
Mobile: +91-9741206402
E-mail ID :[email protected]
http://www.lnties.com

This mail is classified as :
( ) L&T IES Proprietary
( ) L&T IES Confidential
(X) L&T IES Internal Use
( ) L&T IES General Business

Larsen & Toubro Limited

http://www.larsentoubro.com

This Email may contain confidential or privileged information for the intended recipient (s). If you are not the intended recipient, please do not use or disseminate the information, notify the sender and delete it from your system.


2013-02-18 11:24:46

by Girish Bn

[permalink] [raw]
Subject: RE: patch : mac80211:Multicast patch for linux-2.6.28.1 (wl12xx drivers)

SGksDQoNClRoaXMgcGFydGljdWxhciBjaGFuZ2UgaXMgcmVxdWlyZWQgb24gZm9yIHRoZSBtdWx0
aWNhc3QgdG8gd29yayBzdWNjZXNzZnVsbHkgb24gTGludXgga2VybmVsIDIuNi4yOC4yLiBJIHRo
b3VnaHQgdGhyb3VnaCB0aGlzIGZvcnVtIEkgY2FuIG1ha2Ugb3RoZXJzIHRvIHVzZSB0aGlzIHBh
dGNoIHRvIHJlc29sdmUgbXVsdGljYXN0IGlzc3VlLiBJIGFjY2VwdCB0aGF0IEkgYW0gbmV3IHRv
IG9wZW4gc291cmNlLiBJZiBhbnkgcHJvcGVyIHdheSB0byBtYWtlIG11bHRpY2FzdCB0byB3b3Jr
LCBwbGVhc2Ugc3VnZ2VzdCBvdGhlcndpc2UgZGlzY2FyZCB0aGUgcGF0Y2guIEZvciBtZSB0aGlz
IHBhdGNoIGlzIHdvcmtpbmcgdG8gcmVjZWl2ZSBJR01QIHBhY2tldHMgb3ZlciB0aGUgV2lyZWxl
c3MgbmV0d29yaw0KDQpUaGFua3MgJiBSZWdhcmRzLA0KR2lyaXNoDQpMJlQgSUVTLA0KS0lBREIg
SW5kdXN0cmlhbCBBcmVhLA0KSGViYmFsLUhvb3RhZ2FsbGksIE15c29yZSAtIDU3MCAwMTgNClRl
bGVwaG9uZSA6ICBESUQrOTEtODIxLTI0MDU1NTINCk1vYmlsZTogKzkxLTk3NDEyMDY0MDINCkUt
bWFpbCBJRCA6R2lyaXNoLkJOQGxudGllcy5jb20NCnd3dy5sbnRpZXMuY29tDQoNClRoaXMgbWFp
bCBpcyBjbGFzc2lmaWVkIGFzIDoNCiggICkgTCZUIElFUyBQcm9wcmlldGFyeQ0KKCAgKSBMJlQg
SUVTIENvbmZpZGVudGlhbA0KKFgpIEwmVCBJRVMgSW50ZXJuYWwgVXNlDQooICkgTCZUIElFUyBH
ZW5lcmFsIEJ1c2luZXNzDQoNCg0KLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCkZyb206IEpv
aGFubmVzIEJlcmcgW21haWx0bzpqb2hhbm5lc0BzaXBzb2x1dGlvbnMubmV0XQ0KU2VudDogTW9u
ZGF5LCBGZWJydWFyeSAxOCwgMjAxMyA0OjQzIFBNDQpUbzogR2lyaXNoIEJuDQpDYzogbGludXgt
d2lyZWxlc3NAdmdlci5rZXJuZWwub3JnDQpTdWJqZWN0OiBSZTogcGF0Y2ggOiBtYWM4MDIxMTpN
dWx0aWNhc3QgcGF0Y2ggZm9yIGxpbnV4LTIuNi4yOC4xICh3bDEyeHggZHJpdmVycykNCg0KT24g
TW9uLCAyMDEzLTAyLTE4IGF0IDEyOjExICswMTAwLCBKb2hhbm5lcyBCZXJnIHdyb3RlOg0KPiBP
biBNb24sIDIwMTMtMDItMTggYXQgMTE6MDkgKzAwMDAsIEdpcmlzaCBCbiB3cm90ZToNCj4gPiBI
aSBBbGwsDQo+ID4NCj4gPiBUaGUgYmVsb3cgcGF0Y2ggZmlsZSBpcyByZXF1aXJlZCBpbiBvcmRl
ciBmb3IgdGhlIG11bHRpY2FzdGluZyB0bw0KPiA+IHdvcmsgcHJvcGVybHkgb24gTGludXgga2Vy
bmVsIGJlbG93IDMuMiBmb3Igd2wxMnh4IGRyaXZlcnMgZGlmZiAtTmF1ciBhL25ldC9tYWM4MDIx
MS9pZmFjZS5jIGIvbmV0L21hYzgwMjExL2lmYWNlLmMNCj4gPiAtLS0gYS9uZXQvbWFjODAyMTEv
aWZhY2UuYyAgICAgICAgICAyMDEyLTA5LTIyIDIyOjU5OjE1LjAwMDAwMDAwMCArMDUzMA0KPiA+
ICsrKyBiL25ldC9tYWM4MDIxMS9pZmFjZS5jICAgICAgMjAxMy0wMi0wNyAxMjowNjowMy45NTgy
Njg3OTggKzA1MzANCj4gPiBAQCAtODExLDYgKzgxMSw5IEBADQo+ID4gICAgICAgICAgICAgICAg
Lm5kb191bmluaXQgICAgICAgICAgICAgICAgICAgICAgICA9IGllZWU4MDIxMV90ZWFyZG93bl9z
ZGF0YSwNCj4gPiAgICAgICAgICAgICAgICAubmRvX3N0YXJ0X3htaXQgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgPSBpZWVlODAyMTFfc3ViaWZfc3RhcnRfeG1pdCwNCj4gPiAgICAgICAg
ICAgICAgICAubmRvX3NldF9yeF9tb2RlICAgICAgICA9IGllZWU4MDIxMV9zZXRfbXVsdGljYXN0
X2xpc3QsDQo+ID4gKyNpZiAoTElOVVhfVkVSU0lPTl9DT0RFIDwgS0VSTkVMX1ZFUlNJT04oMywy
LDApKQ0KPiA+ICsgICAgICAgICAgICAgLm5kb19zZXRfbXVsdGljYXN0X2xpc3QgPQ0KPiA+ICtp
ZWVlODAyMTFfc2V0X211bHRpY2FzdF9saXN0LCAjZW5kaWYNCj4NCj4gTE9MLg0KDQpBbHNvIHRo
aXM6DQoNCj4gVGhpcyBtYWlsIGlzIGNsYXNzaWZpZWQgYXMgOg0KPiAoICApIEwmVCBJRVMgUHJv
cHJpZXRhcnkNCj4gKCAgKSBMJlQgSUVTIENvbmZpZGVudGlhbA0KPiAoWCkgTCZUIElFUyBJbnRl
cm5hbCBVc2UNCj4gKCApIEwmVCBJRVMgR2VuZXJhbCBCdXNpbmVzcw0KDQoNCkluIG90aGVyIHdv
cmRzLCB5b3UgbmV2ZXIgZXZlbiB3YW50ZWQgbWUgdG8gc2VlIHRoYXQgZW1haWwsIHdoaWNoIGlz
IGp1c3QgYXMgd2VsbCBzaW5jZSBpdCdzIGNvbXBsZXRlbHkgYm9ndXMgZm9yIHVwc3RyZWFtLg0K
DQpqb2hhbm5lcw0KDQpMYXJzZW4gJiBUb3Vicm8gTGltaXRlZA0KDQp3d3cubGFyc2VudG91YnJv
LmNvbQ0KDQpUaGlzIEVtYWlsIG1heSBjb250YWluIGNvbmZpZGVudGlhbCBvciBwcml2aWxlZ2Vk
IGluZm9ybWF0aW9uIGZvciB0aGUgaW50ZW5kZWQgcmVjaXBpZW50IChzKS4gSWYgeW91IGFyZSBu
b3QgdGhlIGludGVuZGVkIHJlY2lwaWVudCwgcGxlYXNlIGRvIG5vdCB1c2Ugb3IgZGlzc2VtaW5h
dGUgdGhlIGluZm9ybWF0aW9uLCBub3RpZnkgdGhlIHNlbmRlciBhbmQgZGVsZXRlIGl0IGZyb20g
eW91ciBzeXN0ZW0uDQo=

2013-02-18 11:11:59

by Johannes Berg

[permalink] [raw]
Subject: Re: patch : mac80211:Multicast patch for linux-2.6.28.1 (wl12xx drivers)

On Mon, 2013-02-18 at 11:09 +0000, Girish Bn wrote:
> Hi All,
>
> The below patch file is required in order for the multicasting to work properly on Linux kernel below 3.2 for wl12xx drivers
> diff -Naur a/net/mac80211/iface.c b/net/mac80211/iface.c
> --- a/net/mac80211/iface.c 2012-09-22 22:59:15.000000000 +0530
> +++ b/net/mac80211/iface.c 2013-02-07 12:06:03.958268798 +0530
> @@ -811,6 +811,9 @@
> .ndo_uninit = ieee80211_teardown_sdata,
> .ndo_start_xmit = ieee80211_subif_start_xmit,
> .ndo_set_rx_mode = ieee80211_set_multicast_list,
> +#if (LINUX_VERSION_CODE < KERNEL_VERSION(3,2,0))
> + .ndo_set_multicast_list = ieee80211_set_multicast_list,
> +#endif

LOL.

johannes


2013-02-18 11:46:05

by Johannes Berg

[permalink] [raw]
Subject: Re: patch : mac80211:Multicast patch for linux-2.6.28.1 (wl12xx drivers)

On Mon, 2013-02-18 at 11:25 +0000, Girish Bn wrote:
> Hi,

(please don't top-post)

> This particular change is required on for the multicast to work
> successfully on Linux kernel 2.6.28.2. I thought through this forum I
> can make others to use this patch to resolve multicast issue. I accept
> that I am new to open source. If any proper way to make multicast to
> work, please suggest otherwise discard the patch. For me this patch is
> working to receive IGMP packets over the Wireless network

This particular patch is not required upstream because upstream has long
moved past 2.6.28(.2). If you need this included in TI's special compat
version you need to talk to them.

In any case, I cannot and will not apply patches to any tree that carry
a "confidential information" footer and/or don't have a sign-off.

johannes


2013-02-18 11:13:20

by Johannes Berg

[permalink] [raw]
Subject: Re: patch : mac80211:Multicast patch for linux-2.6.28.1 (wl12xx drivers)

On Mon, 2013-02-18 at 12:11 +0100, Johannes Berg wrote:
> On Mon, 2013-02-18 at 11:09 +0000, Girish Bn wrote:
> > Hi All,
> >
> > The below patch file is required in order for the multicasting to work properly on Linux kernel below 3.2 for wl12xx drivers
> > diff -Naur a/net/mac80211/iface.c b/net/mac80211/iface.c
> > --- a/net/mac80211/iface.c 2012-09-22 22:59:15.000000000 +0530
> > +++ b/net/mac80211/iface.c 2013-02-07 12:06:03.958268798 +0530
> > @@ -811,6 +811,9 @@
> > .ndo_uninit = ieee80211_teardown_sdata,
> > .ndo_start_xmit = ieee80211_subif_start_xmit,
> > .ndo_set_rx_mode = ieee80211_set_multicast_list,
> > +#if (LINUX_VERSION_CODE < KERNEL_VERSION(3,2,0))
> > + .ndo_set_multicast_list = ieee80211_set_multicast_list,
> > +#endif
>
> LOL.

Also this:

> This mail is classified as :
> ( ) L&T IES Proprietary
> ( ) L&T IES Confidential
> (X) L&T IES Internal Use
> ( ) L&T IES General Business


In other words, you never even wanted me to see that email, which is
just as well since it's completely bogus for upstream.

johannes