2013-03-10 12:41:44

by Andrei Epure

Subject: [PATCH] ath: changed kmalloc to kmemdup

Signed-off-by: Andrei Epure <[email protected]>
---
drivers/net/wireless/ath/ath6kl/usb.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/net/wireless/ath/ath6kl/usb.c b/drivers/net/wireless/ath/ath6kl/usb.c
index 5fcd342..ffa1daa 100644
--- a/drivers/net/wireless/ath/ath6kl/usb.c
+++ b/drivers/net/wireless/ath/ath6kl/usb.c
@@ -856,11 +856,9 @@ static int ath6kl_usb_submit_ctrl_out(struct ath6kl_usb *ar_usb,
int ret;

if (size > 0) {
- buf = kmalloc(size, GFP_KERNEL);
+ buf = kmemdup(data, size, GFP_KERNEL);
if (buf == NULL)
return -ENOMEM;
-
- memcpy(buf, data, size);
}

/* note: if successful returns number of bytes transfered */
--
1.7.10.4

2013-03-18 12:09:27

by Kalle Valo

Subject: Re: [PATCH] ath: changed kmalloc to kmemdup

Andrei Epure <[email protected]> writes:

> Signed-off-by: Andrei Epure <[email protected]>
> ---
> drivers/net/wireless/ath/ath6kl/usb.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath6kl/usb.c b/drivers/net/wireless/ath/ath6kl/usb.c
> index 5fcd342..ffa1daa 100644
> --- a/drivers/net/wireless/ath/ath6kl/usb.c
> +++ b/drivers/net/wireless/ath/ath6kl/usb.c
> @@ -856,11 +856,9 @@ static int ath6kl_usb_submit_ctrl_out(struct ath6kl_usb *ar_usb,
> int ret;
>
> if (size > 0) {
> - buf = kmalloc(size, GFP_KERNEL);
> + buf = kmemdup(data, size, GFP_KERNEL);
> if (buf == NULL)
> return -ENOMEM;
> -
> - memcpy(buf, data, size);
> }

Thanks, applied to ath6kl.git.

--
Kalle Valo

2013-03-10 13:27:26

by Kalle Valo

Subject: Re: [PATCH] ath: changed kmalloc to kmemdup

Andrei Epure <[email protected]> writes:

> Signed-off-by: Andrei Epure <[email protected]>

Thanks, I'll take this. But please prefix ath6kl patches with "ath6kl:"
in the future.

--
Kalle Valo