2013-03-13 22:17:04

by Ben Greear

Subject: question on beacon-loss messages

I am wondering, should the rssi_notify() call only be made if 'beacon' is
true?

I'm seeing lots of beacon-miss events, but when I print out the beacon-loss counters,
they are zero (or much smaller than the number of events I see come out of 'iw').



static void ieee80211_mgd_probe_ap(struct ieee80211_sub_if_data *sdata,
bool beacon)
{
struct ieee80211_if_managed *ifmgd = &sdata->u.mgd;
bool already = false;

if (!ieee80211_sdata_running(sdata))
return;

mutex_lock(&ifmgd->mtx);

if (!ifmgd->associated)
goto out;

mutex_lock(&sdata->local->mtx);

if (sdata->local->tmp_channel || sdata->local->scanning) {
mutex_unlock(&sdata->local->mtx);
goto out;
}

if (beacon)
mlme_dbg_ratelimited(sdata,
"detected beacon loss from AP - probing\n");

ieee80211_cqm_rssi_notify(&sdata->vif,
NL80211_CQM_RSSI_BEACON_LOSS_EVENT, GFP_KERNEL);


Thanks,
Ben

--
Ben Greear <[email protected]>
Candela Technologies Inc http://www.candelatech.com

2013-03-19 20:22:47

by Johannes Berg

Subject: Re: question on beacon-loss messages

On Wed, 2013-03-13 at 15:17 -0700, Ben Greear wrote:
> I am wondering, should the rssi_notify() call only be made if 'beacon' is
> true?

Yes, it does seem so.

johannes