2014-10-19 11:50:26

by Krishna Chaitanya

[permalink] [raw]
Subject: SMPS for AP mode confoguration

Hi,

We are testing SMPS functionality for AP mode. The driver conveys its
capabilities through setting the HT capability which can be set to 0-3.

I wanted to convey support for both Dynamic and Static Powersave
and then control the config through hostapd.conf file. Currently this is
not possible.From driver i can only advertize support for static (or) dynamic
not both (HW_SUPPORTS_* is a different thing which is used in
doing checks at debugfs level).

So if i wanted to configure different modes from hostapd.conf, i
have to change the driver settings as well.

Shouldn't it be the other way around, based on driver's _HW_ flags
we should convey the capabilities to user-space (currently we use
ht_cap for this) and it will configure the mode from the configuration
file. I think the design of SMPS configuration should be changed.


--
Thanks,
Regards,
Chaitanya T K.


2014-10-19 13:21:17

by Eliad Peller

[permalink] [raw]
Subject: Re: SMPS for AP mode confoguration

hi,

On Sun, Oct 19, 2014 at 2:50 PM, Krishna Chaitanya
<[email protected]> wrote:
> We are testing SMPS functionality for AP mode. The driver conveys its
> capabilities through setting the HT capability which can be set to 0-3.
>
> I wanted to convey support for both Dynamic and Static Powersave
> and then control the config through hostapd.conf file. Currently this is
> not possible.From driver i can only advertize support for static (or) dynamic
> not both (HW_SUPPORTS_* is a different thing which is used in
> doing checks at debugfs level).
>
> So if i wanted to configure different modes from hostapd.conf, i
> have to change the driver settings as well.
>
> Shouldn't it be the other way around, based on driver's _HW_ flags
> we should convey the capabilities to user-space (currently we use
> ht_cap for this) and it will configure the mode from the configuration
> file. I think the design of SMPS configuration should be changed.
>
this was recently changed. take a look at this patchset:
http://www.spinics.net/lists/linux-wireless/msg126749.html

we also have a matching supplicant patchset that will probably be
upstreamed soon.

Eliad.

2014-10-19 15:04:01

by Krishna Chaitanya

[permalink] [raw]
Subject: Re: SMPS for AP mode confoguration

On Sun, Oct 19, 2014 at 6:51 PM, Eliad Peller <[email protected]> wrote:
> hi,
>
> On Sun, Oct 19, 2014 at 2:50 PM, Krishna Chaitanya
> <[email protected]> wrote:
>> We are testing SMPS functionality for AP mode. The driver conveys its
>> capabilities through setting the HT capability which can be set to 0-3.
>>
>> I wanted to convey support for both Dynamic and Static Powersave
>> and then control the config through hostapd.conf file. Currently this is
>> not possible.From driver i can only advertize support for static (or) dynamic
>> not both (HW_SUPPORTS_* is a different thing which is used in
>> doing checks at debugfs level).
>>
>> So if i wanted to configure different modes from hostapd.conf, i
>> have to change the driver settings as well.
>>
>> Shouldn't it be the other way around, based on driver's _HW_ flags
>> we should convey the capabilities to user-space (currently we use
>> ht_cap for this) and it will configure the mode from the configuration
>> file. I think the design of SMPS configuration should be changed.
>>
> this was recently changed. take a look at this patchset:
> http://www.spinics.net/lists/linux-wireless/msg126749.html
>
> we also have a matching supplicant patchset that will probably be
> upstreamed soon.

Thanks Ellad, it looks good to me, will try out them once they are up stream.