2016-05-17 22:30:58

by Heinrich Schuchardt

Subject: [PATCH 1/1] net: rsi: eliminate superfluous NULL check

msg is dereferenced before checking against NULL, e.g.
when assigning pad_bytes.
Remove the superfluous check in function rsi_mgmt_pkt_to_core.

Signed-off-by: Heinrich Schuchardt <[email protected]>
---
drivers/net/wireless/rsi/rsi_91x_mgmt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/rsi/rsi_91x_mgmt.c b/drivers/net/wireless/rsi/rsi_91x_mgmt.c
index 40658b6..35c14cc 100644
--- a/drivers/net/wireless/rsi/rsi_91x_mgmt.c
+++ b/drivers/net/wireless/rsi/rsi_91x_mgmt.c
@@ -398,7 +398,7 @@ static int rsi_mgmt_pkt_to_core(struct rsi_common *common,
return -ENOLINK;

msg_len -= pad_bytes;
- if ((msg_len <= 0) || (!msg)) {
+ if (msg_len <= 0) {
rsi_dbg(MGMT_RX_ZONE,
"%s: Invalid rx msg of len = %d\n",
__func__, msg_len);
--
2.1.4

2016-05-19 18:31:37

by David Miller

Subject: Re: [PATCH 1/1] net: rsi: eliminate superfluous NULL check

From: Heinrich Schuchardt <[email protected]>
Date: Wed, 18 May 2016 00:30:41 +0200

> msg is dereferenced before checking against NULL, e.g.
> when assigning pad_bytes.
> Remove the superfluous check in function rsi_mgmt_pkt_to_core.
>
> Signed-off-by: Heinrich Schuchardt <[email protected]>

I'll let the wireless folks pick this up.

2016-06-14 14:18:18

by Kalle Valo

Subject: Re: [1/1] rsi: eliminate superfluous NULL check

Heinrich Schuchardt <[email protected]> wrote:
> msg is dereferenced before checking against NULL, e.g.
> when assigning pad_bytes.
> Remove the superfluous check in function rsi_mgmt_pkt_to_core.
>
> Signed-off-by: Heinrich Schuchardt <[email protected]>

Thanks, 1 patch applied to wireless-drivers-next.git:

9b648d788d78 rsi: eliminate superfluous NULL check

--
Sent by pwcli
https://patchwork.kernel.org/patch/9115441/