2020-04-24 09:46:41

by Kalle Valo

[permalink] [raw]
Subject: Re: [wireless-drivers-next:master 41/48] drivers/net/wireless/realtek/rtw88/mac.c:653:5: sparse: sparse: symbol '__rtw_download_firmware' was not declared. Should it be static?

+ linux-wireless

kbuild test robot <[email protected]> writes:

> tree:
> https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git
> master
> head: 75e69fb11b40ba1256b14f943c7050682c1f5458
> commit: 15d2fcc6b2dea46986e55cd3808c0dbb480a6c8d [41/48] rtw88: add
> legacy firmware download for 8723D devices
> reproduce:
> # apt-get install sparse
> # sparse version: v0.6.1-191-gc51a0382-dirty
> git checkout 15d2fcc6b2dea46986e55cd3808c0dbb480a6c8d
> make ARCH=x86_64 allmodconfig
> make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kbuild test robot <[email protected]>
>
>
> sparse warnings: (new ones prefixed by >>)
>
>>> drivers/net/wireless/realtek/rtw88/mac.c:653:5: sparse: sparse:
>>> symbol '__rtw_download_firmware' was not declared. Should it be
>>> static?
>>> drivers/net/wireless/realtek/rtw88/mac.c:817:5: sparse: sparse:
>>> symbol '__rtw_download_firmware_legacy' was not declared. Should it
>>> be static?
>
> Please review and possibly fold the followup patch.

Tony, please send the patch via linux-wireless so that patchwork sees
it.

--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches


2020-04-25 02:58:39

by kbuild test robot

[permalink] [raw]
Subject: [RFC PATCH wireless-drivers-next] rtw88: __rtw_download_firmware() can be static


Fixes: 15d2fcc6b2de ("rtw88: add legacy firmware download for 8723D devices")
Signed-off-by: kbuild test robot <[email protected]>
---
mac.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/realtek/rtw88/mac.c b/drivers/net/wireless/realtek/rtw88/mac.c
index 6092604abfb9e..3cc0b363df8ce 100644
--- a/drivers/net/wireless/realtek/rtw88/mac.c
+++ b/drivers/net/wireless/realtek/rtw88/mac.c
@@ -650,7 +650,7 @@ static void download_firmware_end_flow(struct rtw_dev *rtwdev)
rtw_write16(rtwdev, REG_MCUFW_CTRL, fw_ctrl);
}

-int __rtw_download_firmware(struct rtw_dev *rtwdev, struct rtw_fw_state *fw)
+static int __rtw_download_firmware(struct rtw_dev *rtwdev, struct rtw_fw_state *fw)
{
struct rtw_backup_info bckp[DLFW_RESTORE_REG_NUM];
const u8 *data = fw->firmware->data;
@@ -814,7 +814,7 @@ static int download_firmware_validate_legacy(struct rtw_dev *rtwdev)
return -EINVAL;
}

-int __rtw_download_firmware_legacy(struct rtw_dev *rtwdev, struct rtw_fw_state *fw)
+static int __rtw_download_firmware_legacy(struct rtw_dev *rtwdev, struct rtw_fw_state *fw)
{
int ret = 0;