2021-03-06 14:39:20

by Jia-Ju Bai

[permalink] [raw]
Subject: [PATCH] ti: wlcore: fix error return code of wl1271_suspend()

When wl is NULL, no error return code of wl1271_suspend() is assigned.
To fix this bug, ret is assigned with -EINVAL in this case.

Reported-by: TOTE Robot <[email protected]>
Signed-off-by: Jia-Ju Bai <[email protected]>
---
drivers/net/wireless/ti/wlcore/sdio.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/net/wireless/ti/wlcore/sdio.c b/drivers/net/wireless/ti/wlcore/sdio.c
index 9fd8cf2d270c..a040d595a43a 100644
--- a/drivers/net/wireless/ti/wlcore/sdio.c
+++ b/drivers/net/wireless/ti/wlcore/sdio.c
@@ -390,6 +390,7 @@ static int wl1271_suspend(struct device *dev)

if (!wl) {
dev_err(dev, "no wilink module was probed\n");
+ ret = -EINVAL;
goto out;
}

--
2.17.1


2021-04-18 05:57:14

by Kalle Valo

[permalink] [raw]
Subject: Re: [PATCH] ti: wlcore: fix error return code of wl1271_suspend()

Jia-Ju Bai <[email protected]> wrote:

> When wl is NULL, no error return code of wl1271_suspend() is assigned.
> To fix this bug, ret is assigned with -EINVAL in this case.
>
> Reported-by: TOTE Robot <[email protected]>
> Signed-off-by: Jia-Ju Bai <[email protected]>

Someone needs to review this.

Patch set to Changes Requested.

--
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches