2021-03-16 15:38:34

by Torsten Hilbrich

[permalink] [raw]
Subject: [iwlwifi] v5.12-rc1: Unable to move phy0 to other network namespace

Hello,

starting with kernel v5.12-rc1 (and still not working in v5.12-rc3) I'm no longer able to move a wlan interface into another namespace.

I have created a new network namespace, like in the following example:

# ip netns add black

Then I move the phy0 interface to that network namespace. I then expect the wlan0 interface to be removed from the initial network namespace and then to appear in the new one.

# iw phy phy0 set netns name black

However, starting with v5.12-rc1 (last known to be working with v5.11) the command never finishes execution. Instead, I get a number of rntl warnings and a soft hangup.

Kernel log is attached.

Here some relevant excerpts:

2021-03-16 11:26:49.124 kernel: iwlwifi 0000:3a:00.0: Detected Intel(R) Dual Band Wireless AC 8265, REV=0x230

2021-03-16 11:27:14.269 kernel: WARNING: CPU: 0 PID: 467 at net/core/dev.c:10988 dev_change_net_namespace+0x44d/0x480
2021-03-16 11:27:14.269 kernel: WARNING: CPU: 0 PID: 467 at net/core/dev.c:381 unlist_netdevice+0xdb/0xf0
2021-03-16 11:27:14.275 kernel: WARNING: CPU: 0 PID: 467 at net/core/dev.c:2054 call_netdevice_notifiers_info+0x7c/0x80
2021-03-16 11:27:14.275 kernel: WARNING: CPU: 0 PID: 467 at net/core/fib_rules.c:1227 fib_rules_event+0x18f/0x1a0
2021-03-16 11:27:14.275 kernel: WARNING: CPU: 0 PID: 467 at net/ipv4/devinet.c:1526 inetdev_event+0x39f/0x5c0
2021-03-16 11:27:14.276 kernel: WARNING: CPU: 0 PID: 467 at net/ipv4/devinet.c:309 inetdev_event+0x4a9/0x5c0
2021-03-16 11:27:14.276 kernel: WARNING: CPU: 0 PID: 467 at net/ipv4/igmp.c:1793 ip_mc_destroy_dev+0x67/0x70
2021-03-16 11:27:14.277 kernel: WARNING: CPU: 0 PID: 467 at net/ipv4/igmp.c:1721 ip_mc_down+0x84/0x90
2021-03-16 11:27:14.277 kernel: WARNING: CPU: 0 PID: 467 at net/ipv4/igmp.c:1664 __ip_mc_dec_group+0x162/0x1a0

2021-03-16 11:27:14.278 kernel: ---[ end trace 6b632a15496dddfa ]---
2021-03-16 11:30:24.753 kernel: INFO: task iw:467 blocked for more than 122 seconds.
2021-03-16 11:30:24.753 kernel: Tainted: P W O 5.12.0-devel+ #1
2021-03-16 11:30:24.753 kernel: "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message.
2021-03-16 11:30:24.753 kernel: task:iw state:D stack:12720 pid: 467 ppid: 457 flags:0x00004000
2021-03-16 11:30:24.753 kernel: Call Trace:
2021-03-16 11:30:24.753 kernel: __schedule+0x275/0x660
2021-03-16 11:30:24.753 kernel: schedule+0x3c/0xa0
2021-03-16 11:30:24.753 kernel: schedule_preempt_disabled+0xa/0x10
2021-03-16 11:30:24.753 kernel: __mutex_lock.isra.12+0x2c7/0x4c0
2021-03-16 11:30:24.753 kernel: ? trace_hardirqs_on+0x2a/0xb0
2021-03-16 11:30:24.753 kernel: ? skb_dequeue+0x57/0x70
2021-03-16 11:30:24.753 kernel: cfg80211_netdev_notifier_call+0x23d/0x3e0
2021-03-16 11:30:24.753 kernel: raw_notifier_call_chain+0x41/0x50
2021-03-16 11:30:24.753 kernel: dev_change_net_namespace+0xe1/0x480
2021-03-16 11:30:24.753 kernel: ? __rtnl_unlock+0x25/0x50
2021-03-16 11:30:24.753 kernel: cfg80211_switch_netns+0x65/0x1c0
2021-03-16 11:30:24.753 kernel: nl80211_wiphy_netns+0x4b/0xc0
2021-03-16 11:30:24.753 kernel: genl_family_rcv_msg_doit.isra.17+0x10f/0x150
2021-03-16 11:30:24.753 kernel: genl_rcv_msg+0xde/0x1e0
2021-03-16 11:30:24.753 kernel: ? nl80211_authenticate+0x310/0x310
2021-03-16 11:30:24.753 kernel: ? genl_family_rcv_msg_doit.isra.17+0x150/0x150
2021-03-16 11:30:24.753 kernel: netlink_rcv_skb+0x50/0x100
2021-03-16 11:30:24.753 kernel: genl_rcv+0x24/0x40
2021-03-16 11:30:24.754 kernel: netlink_unicast+0x1a5/0x280
2021-03-16 11:30:24.754 kernel: netlink_sendmsg+0x21b/0x450
2021-03-16 11:30:24.754 kernel: sock_sendmsg+0x5b/0x60
2021-03-16 11:30:24.754 kernel: ____sys_sendmsg+0x1ad/0x1e0
2021-03-16 11:30:24.754 kernel: ? copy_msghdr_from_user+0x5c/0x90
2021-03-16 11:30:24.754 kernel: ___sys_sendmsg+0x84/0xc0
2021-03-16 11:30:24.754 kernel: ? do_filp_open+0xa7/0x100
2021-03-16 11:30:24.754 kernel: __sys_sendmsg+0x51/0x90
2021-03-16 11:30:24.754 kernel: do_syscall_64+0x33/0x40
2021-03-16 11:30:24.754 kernel: entry_SYSCALL_64_after_hwframe+0x44/0xae


With regards,

Torsten


Attachments:
dmesg.log (126.80 kB)

2021-03-16 15:43:35

by Johannes Berg

[permalink] [raw]
Subject: Re: [iwlwifi] v5.12-rc1: Unable to move phy0 to other network namespace

On Tue, 2021-03-16 at 12:38 +0100, Torsten Hilbrich wrote:
> Hello,
>
> starting with kernel v5.12-rc1 (and still not working in v5.12-rc3) I'm
> no longer able to move a wlan interface into another namespace.
>
> I have created a new network namespace, like in the following example:
>
> # ip netns add black
>
> Then I move the phy0 interface to that network namespace. I then expect the wlan0 interface to be removed from the initial network namespace and then to appear in the new one.
>
> # iw phy phy0 set netns name black
>
> However, starting with v5.12-rc1 (last known to be working with v5.11) the command never finishes execution. Instead, I get a number of rntl warnings and a soft hangup

Yes, oops, known bug, fix is here:

https://patchwork.kernel.org/project/linux-wireless/patch/20210310215839.eadf7[email protected]/

I'll get it sent upstream soon.

johannes

2021-03-16 15:55:22

by Torsten Hilbrich

[permalink] [raw]
Subject: Re: [iwlwifi] v5.12-rc1: Unable to move phy0 to other network namespace

On 16.03.21 13:09, Johannes Berg wrote:
> On Tue, 2021-03-16 at 12:38 +0100, Torsten Hilbrich wrote:
>> Hello,
>>
>> starting with kernel v5.12-rc1 (and still not working in v5.12-rc3) I'm
>> no longer able to move a wlan interface into another namespace.
>>
>> I have created a new network namespace, like in the following example:
>>
>> # ip netns add black
>>
>> Then I move the phy0 interface to that network namespace. I then expect the wlan0 interface to be removed from the initial network namespace and then to appear in the new one.
>>
>> # iw phy phy0 set netns name black
>>
>> However, starting with v5.12-rc1 (last known to be working with v5.11) the command never finishes execution. Instead, I get a number of rntl warnings and a soft hangup
>
> Yes, oops, known bug, fix is here:
>
> https://patchwork.kernel.org/project/linux-wireless/patch/202103[email protected]changeid/
>
> I'll get it sent upstream soon.

I can confirm that the patch works for me.

Thanks,

Torsten

2021-03-16 21:22:54

by Sid Hayn

[permalink] [raw]
Subject: Re: [iwlwifi] v5.12-rc1: Unable to move phy0 to other network namespace

The fix for this was submitted as [PATCH] nl80211: fix locking for
wireless device netns change

It looks like johill needs to accept his own change still:
https://patchwork.kernel.org/project/linux-wireless/patch/202103[email protected]changeid/

Thanks,
Zero

On Tue, Mar 16, 2021 at 2:48 PM Torsten Hilbrich
<[email protected]> wrote:
>
> Hello,
>
> starting with kernel v5.12-rc1 (and still not working in v5.12-rc3) I'm no longer able to move a wlan interface into another namespace.
>
> I have created a new network namespace, like in the following example:
>
> # ip netns add black
>
> Then I move the phy0 interface to that network namespace. I then expect the wlan0 interface to be removed from the initial network namespace and then to appear in the new one.
>
> # iw phy phy0 set netns name black
>
> However, starting with v5.12-rc1 (last known to be working with v5.11) the command never finishes execution. Instead, I get a number of rntl warnings and a soft hangup.
>
> Kernel log is attached.
>
> Here some relevant excerpts:
>
> 2021-03-16 11:26:49.124 kernel: iwlwifi 0000:3a:00.0: Detected Intel(R) Dual Band Wireless AC 8265, REV=0x230
>
> 2021-03-16 11:27:14.269 kernel: WARNING: CPU: 0 PID: 467 at net/core/dev.c:10988 dev_change_net_namespace+0x44d/0x480
> 2021-03-16 11:27:14.269 kernel: WARNING: CPU: 0 PID: 467 at net/core/dev.c:381 unlist_netdevice+0xdb/0xf0
> 2021-03-16 11:27:14.275 kernel: WARNING: CPU: 0 PID: 467 at net/core/dev.c:2054 call_netdevice_notifiers_info+0x7c/0x80
> 2021-03-16 11:27:14.275 kernel: WARNING: CPU: 0 PID: 467 at net/core/fib_rules.c:1227 fib_rules_event+0x18f/0x1a0
> 2021-03-16 11:27:14.275 kernel: WARNING: CPU: 0 PID: 467 at net/ipv4/devinet.c:1526 inetdev_event+0x39f/0x5c0
> 2021-03-16 11:27:14.276 kernel: WARNING: CPU: 0 PID: 467 at net/ipv4/devinet.c:309 inetdev_event+0x4a9/0x5c0
> 2021-03-16 11:27:14.276 kernel: WARNING: CPU: 0 PID: 467 at net/ipv4/igmp.c:1793 ip_mc_destroy_dev+0x67/0x70
> 2021-03-16 11:27:14.277 kernel: WARNING: CPU: 0 PID: 467 at net/ipv4/igmp.c:1721 ip_mc_down+0x84/0x90
> 2021-03-16 11:27:14.277 kernel: WARNING: CPU: 0 PID: 467 at net/ipv4/igmp.c:1664 __ip_mc_dec_group+0x162/0x1a0
>
> 2021-03-16 11:27:14.278 kernel: ---[ end trace 6b632a15496dddfa ]---
> 2021-03-16 11:30:24.753 kernel: INFO: task iw:467 blocked for more than 122 seconds.
> 2021-03-16 11:30:24.753 kernel: Tainted: P W O 5.12.0-devel+ #1
> 2021-03-16 11:30:24.753 kernel: "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message.
> 2021-03-16 11:30:24.753 kernel: task:iw state:D stack:12720 pid: 467 ppid: 457 flags:0x00004000
> 2021-03-16 11:30:24.753 kernel: Call Trace:
> 2021-03-16 11:30:24.753 kernel: __schedule+0x275/0x660
> 2021-03-16 11:30:24.753 kernel: schedule+0x3c/0xa0
> 2021-03-16 11:30:24.753 kernel: schedule_preempt_disabled+0xa/0x10
> 2021-03-16 11:30:24.753 kernel: __mutex_lock.isra.12+0x2c7/0x4c0
> 2021-03-16 11:30:24.753 kernel: ? trace_hardirqs_on+0x2a/0xb0
> 2021-03-16 11:30:24.753 kernel: ? skb_dequeue+0x57/0x70
> 2021-03-16 11:30:24.753 kernel: cfg80211_netdev_notifier_call+0x23d/0x3e0
> 2021-03-16 11:30:24.753 kernel: raw_notifier_call_chain+0x41/0x50
> 2021-03-16 11:30:24.753 kernel: dev_change_net_namespace+0xe1/0x480
> 2021-03-16 11:30:24.753 kernel: ? __rtnl_unlock+0x25/0x50
> 2021-03-16 11:30:24.753 kernel: cfg80211_switch_netns+0x65/0x1c0
> 2021-03-16 11:30:24.753 kernel: nl80211_wiphy_netns+0x4b/0xc0
> 2021-03-16 11:30:24.753 kernel: genl_family_rcv_msg_doit.isra.17+0x10f/0x150
> 2021-03-16 11:30:24.753 kernel: genl_rcv_msg+0xde/0x1e0
> 2021-03-16 11:30:24.753 kernel: ? nl80211_authenticate+0x310/0x310
> 2021-03-16 11:30:24.753 kernel: ? genl_family_rcv_msg_doit.isra.17+0x150/0x150
> 2021-03-16 11:30:24.753 kernel: netlink_rcv_skb+0x50/0x100
> 2021-03-16 11:30:24.753 kernel: genl_rcv+0x24/0x40
> 2021-03-16 11:30:24.754 kernel: netlink_unicast+0x1a5/0x280
> 2021-03-16 11:30:24.754 kernel: netlink_sendmsg+0x21b/0x450
> 2021-03-16 11:30:24.754 kernel: sock_sendmsg+0x5b/0x60
> 2021-03-16 11:30:24.754 kernel: ____sys_sendmsg+0x1ad/0x1e0
> 2021-03-16 11:30:24.754 kernel: ? copy_msghdr_from_user+0x5c/0x90
> 2021-03-16 11:30:24.754 kernel: ___sys_sendmsg+0x84/0xc0
> 2021-03-16 11:30:24.754 kernel: ? do_filp_open+0xa7/0x100
> 2021-03-16 11:30:24.754 kernel: __sys_sendmsg+0x51/0x90
> 2021-03-16 11:30:24.754 kernel: do_syscall_64+0x33/0x40
> 2021-03-16 11:30:24.754 kernel: entry_SYSCALL_64_after_hwframe+0x44/0xae
>
>
> With regards,
>
> Torsten
>