2021-03-22 21:52:42

by Arnd Bergmann

[permalink] [raw]
Subject: [PATCH net-next] iwlwifi: fix old-style-declaration warning

From: Arnd Bergmann <[email protected]>

The correct order is 'static const', not 'const static', as seen from
make W=1:

drivers/net/wireless/intel/iwlwifi/mvm/rfi.c:14:1: error: 'static' is not at beginning of declaration [-Werror=old-style-declaration]

Fixes: 21254908cbe9 ("iwlwifi: mvm: add RFI-M support")
Signed-off-by: Arnd Bergmann <[email protected]>
---
drivers/net/wireless/intel/iwlwifi/mvm/rfi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/rfi.c b/drivers/net/wireless/intel/iwlwifi/mvm/rfi.c
index 873919048143..4d5a99cbcc9d 100644
--- a/drivers/net/wireless/intel/iwlwifi/mvm/rfi.c
+++ b/drivers/net/wireless/intel/iwlwifi/mvm/rfi.c
@@ -11,7 +11,7 @@
* DDR needs frequency in units of 16.666MHz, so provide FW with the
* frequency values in the adjusted format.
*/
-const static struct iwl_rfi_lut_entry iwl_rfi_table[IWL_RFI_LUT_SIZE] = {
+static const struct iwl_rfi_lut_entry iwl_rfi_table[IWL_RFI_LUT_SIZE] = {
/* LPDDR4 */

/* frequency 3733MHz */
--
2.29.2


2021-03-23 08:05:49

by Coelho, Luciano

[permalink] [raw]
Subject: Re: [PATCH net-next] iwlwifi: fix old-style-declaration warning

On Mon, 2021-03-22 at 22:51 +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <[email protected]>
>
> The correct order is 'static const', not 'const static', as seen from
> make W=1:
>
> drivers/net/wireless/intel/iwlwifi/mvm/rfi.c:14:1: error: 'static' is not at beginning of declaration [-Werror=old-style-declaration]
>
> Fixes: 21254908cbe9 ("iwlwifi: mvm: add RFI-M support")
> Signed-off-by: Arnd Bergmann <[email protected]>
> ---

Thanks, Arnd! But I just applied the patch Wei Yongjun submitted, so
we'll go with that one.

--
Cheers,
Luca.