2021-04-23 09:50:29

by zuoqilin1

Subject: [PATCH] wireless: Simplify expression

From: zuoqilin <[email protected]>

It is not necessary to define the variable ret to receive
the return value of the get_bssid() method.

Signed-off-by: zuoqilin <[email protected]>
---
drivers/net/wireless/rndis_wlan.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/net/wireless/rndis_wlan.c b/drivers/net/wireless/rndis_wlan.c
index 9fe7755..63ce244 100644
--- a/drivers/net/wireless/rndis_wlan.c
+++ b/drivers/net/wireless/rndis_wlan.c
@@ -1036,14 +1036,11 @@ static bool is_associated(struct usbnet *usbdev)
{
struct rndis_wlan_private *priv = get_rndis_wlan_priv(usbdev);
u8 bssid[ETH_ALEN];
- int ret;

if (!priv->radio_on)
return false;

- ret = get_bssid(usbdev, bssid);
-
- return (ret == 0 && !is_zero_ether_addr(bssid));
+ return (get_bssid(usbdev, bssid) == 0 && !is_zero_ether_addr(bssid));
}

static int disassociate(struct usbnet *usbdev, bool reset_ssid)
--
1.9.1

2021-06-15 13:36:14

by Kalle Valo

Subject: Re: rndis_wlan: simplify is_associated()

[email protected] wrote:

> From: zuoqilin <[email protected]>
>
> It is not necessary to define the variable ret to receive
> the return value of the get_bssid() method.
>
> Signed-off-by: zuoqilin <[email protected]>

Patch applied to wireless-drivers-next.git, thanks.

ad4d74cd8177 rndis_wlan: simplify is_associated()

--
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches