2021-05-10 15:18:26

by Sean Wang

[permalink] [raw]
Subject: [PATCH 3/9] mt76: connac: fw_own rely on all packet memory all being free

From: Sean Wang <[email protected]>

If the device is MMIO-based, we must ensure all TxD/TxP on the host
memory all being consumed by the device prior to safely switching to
fw_own state.

Fixes: ec7bd7b4a9c0 ("mt76: connac: check wake refcount in mcu_fw_pmctrl")
Reviewed-by: Lorenzo Bianconi <[email protected]>
Signed-off-by: Sean Wang <[email protected]>
drivers/net/wireless/mediatek/mt76/mt76_connac.h | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/drivers/net/wireless/mediatek/mt76/mt76_connac.h b/drivers/net/wireless/mediatek/mt76/mt76_connac.h
index 2b1150bf8d3d..a588d2c39870 100644
--- a/drivers/net/wireless/mediatek/mt76/mt76_connac.h
+++ b/drivers/net/wireless/mediatek/mt76/mt76_connac.h
@@ -133,8 +133,12 @@ mt76_connac_pm_unref(struct mt76_connac_pm *pm)
static inline bool
mt76_connac_skip_fw_pmctrl(struct mt76_phy *phy, struct mt76_connac_pm *pm)
+ struct mt76_dev *dev = phy->dev;
bool ret;

+ if (dev->token_count)
+ return true;
ret = pm->wake.count || test_and_set_bit(MT76_STATE_PM, &phy->state);