On Tue, May 18, 2021 at 08:48:39PM +0300, Kalle Valo wrote:
> Greg Kroah-Hartman <[email protected]> writes:
>
> > There is no need to keep around the dentry pointers for the debugfs
> > files as they will all be automatically removed when the subdir is
> > removed. So save the space and logic involved in keeping them around by
> > just getting rid of them entirely.
> >
> > By doing this change, we remove one of the last in-kernel user that was
> > storing the result of debugfs_create_bool(), so that api can be cleaned
> > up.
> >
> > Cc: Larry Finger <[email protected]>
> > Cc: Kalle Valo <[email protected]>
> > Cc: "David S. Miller" <[email protected]>
> > Cc: Jakub Kicinski <[email protected]>
> > Cc: [email protected]
> > Cc: [email protected]
> > Cc: [email protected]
> > Cc: [email protected]
> > Signed-off-by: Greg Kroah-Hartman <[email protected]>
> > ---
> > .../net/wireless/broadcom/b43legacy/debugfs.c | 29 ++++---------------
> > .../net/wireless/broadcom/b43legacy/debugfs.h | 3 --
> > 2 files changed, 5 insertions(+), 27 deletions(-)
> >
> > Note, I can take this through my debugfs tree if wanted, that way I can
> > clean up the debugfs_create_bool() api at the same time. Otherwise it's
> > fine, I can wait until next -rc1 for that to happen.
>
> Acked-by: Kalle Valo <[email protected]>
Thanks for the ack!