2021-07-06 11:19:43

by Kirti Wankhede

[permalink] [raw]
Subject: Re: [PATCH] bus: Make remove callback return void

On 7/6/2021 3:20 PM, Uwe Kleine-König wrote:
> The driver core ignores the return value of this callback because there
> is only little it can do when a device disappears.
> This is the final bit of a long lasting cleanup quest where several
> buses were converted to also return void from their remove callback.
> Additionally some resource leaks were fixed that were caused by drivers
> returning an error code in the expectation that the driver won't go
> away.
> With struct bus_type::remove returning void it's prevented that newly
> implemented buses return an ignored error code and so don't anticipate
> wrong expectations for driver authors.
> Signed-off-by: Uwe Kleine-König <[email protected]>

> drivers/vfio/mdev/mdev_driver.c | 4 +---

Acked-by: Kirti Wankhede <[email protected]>