2021-07-06 15:07:55

by Yehezkel Bernat

[permalink] [raw]
Subject: Re: [PATCH] bus: Make remove callback return void

On Tue, Jul 6, 2021 at 12:50 PM Uwe Kleine-König
<[email protected]> wrote:
> The driver core ignores the return value of this callback because there
> is only little it can do when a device disappears.
> This is the final bit of a long lasting cleanup quest where several
> buses were converted to also return void from their remove callback.
> Additionally some resource leaks were fixed that were caused by drivers
> returning an error code in the expectation that the driver won't go
> away.
> With struct bus_type::remove returning void it's prevented that newly
> implemented buses return an ignored error code and so don't anticipate
> wrong expectations for driver authors.
> Signed-off-by: Uwe Kleine-König <[email protected]>
> ---

> drivers/thunderbolt/domain.c | 4 +---

For Thunderbolt:

Acked-by: Yehezkel Bernat <[email protected]>