2021-07-15 14:30:15

by Thomas Bogendoerfer

[permalink] [raw]
Subject: Re: [PATCH v2 4/4] bus: Make remove callback return void

On Tue, Jul 06, 2021 at 05:48:03PM +0200, Uwe Kleine-K?nig wrote:
> The driver core ignores the return value of this callback because there
> is only little it can do when a device disappears.
> This is the final bit of a long lasting cleanup quest where several
> buses were converted to also return void from their remove callback.
> Additionally some resource leaks were fixed that were caused by drivers
> returning an error code in the expectation that the driver won't go
> away.
> With struct bus_type::remove returning void it's prevented that newly
> implemented buses return an ignored error code and so don't anticipate
> wrong expectations for driver authors.
> Acked-by: Russell King (Oracle) <[email protected]> (For ARM, Amba and related parts)
> Acked-by: Mark Brown <[email protected]>
> Acked-by: Chen-Yu Tsai <[email protected]> (for drivers/bus/sunxi-rsb.c)
> Acked-by: Pali Roh?r <[email protected]>
> Acked-by: Mauro Carvalho Chehab <[email protected]> (for drivers/media)
> Acked-by: Hans de Goede <[email protected]> (For drivers/platform)
> Acked-by: Alexandre Belloni <[email protected]>
> Acked-By: Vinod Koul <[email protected]>
> Acked-by: Juergen Gross <[email protected]> (For Xen)
> Acked-by: Lee Jones <[email protected]> (For drivers/mfd)
> Acked-by: Johannes Thumshirn <[email protected]> (For drivers/mcb)
> Acked-by: Johan Hovold <[email protected]>
> Acked-by: Srinivas Kandagatla <[email protected]> (For drivers/slimbus)
> Acked-by: Kirti Wankhede <[email protected]> (For drivers/vfio)
> Acked-by: Maximilian Luz <[email protected]>
> Acked-by: Heikki Krogerus <[email protected]> (For ulpi and typec)
> Acked-by: Samuel Iglesias Gons?lvez <[email protected]> (For ipack)
> Reviewed-by: Tom Rix <[email protected]> (For fpga)
> Acked-by: Geoff Levand <[email protected]> (For ps3)
> Signed-off-by: Uwe Kleine-K?nig <[email protected]>
> ---
> [...]
> arch/mips/sgi-ip22/ip22-gio.c | 3 +--

Acked-by: Thomas Bogendoerfer <[email protected]>

Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]