2021-11-22 15:10:36

by Deren Wu

[permalink] [raw]
Subject: [PATCH] mt76: fix timestamp check in tx_status

From: Deren Wu <[email protected]>

Should keep SKBs only if timeout timestamp is still after jiffies.
Otherwise, report tx status and drop it direclty.

Fixes: bd1e3e7b693c ("mt76: introduce packet_id idr")
Signed-off-by: Deren Wu <[email protected]>
---
drivers/net/wireless/mediatek/mt76/tx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/mediatek/mt76/tx.c b/drivers/net/wireless/mediatek/mt76/tx.c
index 11719ef034d8..6b8c9dc80542 100644
--- a/drivers/net/wireless/mediatek/mt76/tx.c
+++ b/drivers/net/wireless/mediatek/mt76/tx.c
@@ -173,7 +173,7 @@ mt76_tx_status_skb_get(struct mt76_dev *dev, struct mt76_wcid *wcid, int pktid,
if (!(cb->flags & MT_TX_CB_DMA_DONE))
continue;

- if (!time_is_after_jiffies(cb->jiffies +
+ if (time_is_after_jiffies(cb->jiffies +
MT_TX_STATUS_SKB_TIMEOUT))
continue;
}
--
2.18.0



2021-11-22 16:00:56

by Felix Fietkau

[permalink] [raw]
Subject: Re: [PATCH] mt76: fix timestamp check in tx_status


On 2021-11-22 16:10, Deren Wu wrote:
> From: Deren Wu <[email protected]>
>
> Should keep SKBs only if timeout timestamp is still after jiffies.
> Otherwise, report tx status and drop it direclty.
>
> Fixes: bd1e3e7b693c ("mt76: introduce packet_id idr")
> Signed-off-by: Deren Wu <[email protected]>

Acked-by: Felix Fietkau <[email protected]>

Kalle, please queue this for 5.16

- Felix

2021-11-22 18:24:40

by Kalle Valo

[permalink] [raw]
Subject: Re: [PATCH] mt76: fix timestamp check in tx_status

Felix Fietkau <[email protected]> writes:

> On 2021-11-22 16:10, Deren Wu wrote:
>> From: Deren Wu <[email protected]>
>>
>> Should keep SKBs only if timeout timestamp is still after jiffies.
>> Otherwise, report tx status and drop it direclty.
>>
>> Fixes: bd1e3e7b693c ("mt76: introduce packet_id idr")
>> Signed-off-by: Deren Wu <[email protected]>
>
> Acked-by: Felix Fietkau <[email protected]>
>
> Kalle, please queue this for 5.16

Ok, assigned the patch to me on patchwork.

(A feature request for patchwork devs: assign patches based on email
commands)

--
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

2021-11-24 17:21:37

by Kalle Valo

[permalink] [raw]
Subject: Re: [PATCH] mt76: fix timestamp check in tx_status

Deren Wu <[email protected]> wrote:

> From: Deren Wu <[email protected]>
>
> Should keep SKBs only if timeout timestamp is still after jiffies.
> Otherwise, report tx status and drop it direclty.
>
> Fixes: bd1e3e7b693c ("mt76: introduce packet_id idr")
> Signed-off-by: Deren Wu <[email protected]>
> Acked-by: Felix Fietkau <[email protected]>

Patch applied to wireless-drivers.git, thanks.

ebb75b1b43d3 mt76: fix timestamp check in tx_status

--
https://patchwork.kernel.org/project/linux-wireless/patch/7[email protected]mediatek.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches