2022-05-06 11:26:25

by Jiapeng Chong

[permalink] [raw]
Subject: [PATCH] ssb: remove unreachable code

Clean up the following smatch warning:

drivers/ssb/pci.c:917 ssb_pci_sprom_get() warn: ignoring unreachable
code.

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Jiapeng Chong <[email protected]>
---
drivers/ssb/pci.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/ssb/pci.c b/drivers/ssb/pci.c
index 148bcb99c212..493bebbba521 100644
--- a/drivers/ssb/pci.c
+++ b/drivers/ssb/pci.c
@@ -914,7 +914,6 @@ static int ssb_pci_sprom_get(struct ssb_bus *bus,
err = 0;
goto out_free;
}
- pr_warn("WARNING: Invalid SPROM CRC (corrupt SPROM)\n");
}
}
err = sprom_extract(bus, sprom, buf, bus->sprom_size);
--
2.20.1.7.g153144c



2022-05-09 06:00:11

by Michael Büsch

[permalink] [raw]
Subject: Re: [PATCH] ssb: remove unreachable code

On Fri, 6 May 2022 15:58:14 +0800
Jiapeng Chong <[email protected]> wrote:

> Clean up the following smatch warning:
>
> drivers/ssb/pci.c:917 ssb_pci_sprom_get() warn: ignoring unreachable
> code.
>
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Jiapeng Chong <[email protected]>
> ---
> drivers/ssb/pci.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/ssb/pci.c b/drivers/ssb/pci.c
> index 148bcb99c212..493bebbba521 100644
> --- a/drivers/ssb/pci.c
> +++ b/drivers/ssb/pci.c
> @@ -914,7 +914,6 @@ static int ssb_pci_sprom_get(struct ssb_bus *bus,
> err = 0;
> goto out_free;
> }
> - pr_warn("WARNING: Invalid SPROM CRC (corrupt
> SPROM)\n"); }
> }
> err = sprom_extract(bus, sprom, buf, bus->sprom_size);



Acked-by: Michael Büsch <[email protected]>

--
Michael Büsch
https://bues.ch/

Attachments:
(No filename) (849.00 B)
OpenPGP digital signature

2022-05-11 07:19:11

by Kalle Valo

[permalink] [raw]
Subject: Re: [PATCH] ssb: remove unreachable code

Jiapeng Chong <[email protected]> wrote:

> Clean up the following smatch warning:
>
> drivers/ssb/pci.c:917 ssb_pci_sprom_get() warn: ignoring unreachable
> code.
>
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Jiapeng Chong <[email protected]>
> Acked-by: Michael Büsch <[email protected]>

Patch applied to wireless-next.git, thanks.

84dc992e23df ssb: remove unreachable code

--
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches