2022-06-06 05:21:50

by CGEL

Subject: [PATCH] staging: wfx: Remove redundant NULL check before release_firmware() call

From: Minghao Chi <[email protected]>

release_firmware() checks for NULL pointers internally so checking
before calling it is redundant.

Reported-by: Zeal Robot <[email protected]>
Signed-off-by: Minghao Chi <[email protected]>
---
drivers/net/wireless/silabs/wfx/fwio.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/wireless/silabs/wfx/fwio.c b/drivers/net/wireless/silabs/wfx/fwio.c
index 3d1b8a135dc0..52c7f560b062 100644
--- a/drivers/net/wireless/silabs/wfx/fwio.c
+++ b/drivers/net/wireless/silabs/wfx/fwio.c
@@ -286,8 +286,7 @@ static int load_firmware_secure(struct wfx_dev *wdev)

error:
kfree(buf);
- if (fw)
- release_firmware(fw);
+ release_firmware(fw);
if (ret)
print_boot_status(wdev);
return ret;
--
2.25.1

2022-06-06 07:08:33

by Jérôme Pouiller

Subject: Re: [PATCH] staging: wfx: Remove redundant NULL check before release_firmware() call

On Monday 6 June 2022 03:42:37 CEST [email protected] wrote:
> From: Minghao Chi <[email protected]>
>
> release_firmware() checks for NULL pointers internally so checking
> before calling it is redundant.
>
> Reported-by: Zeal Robot <[email protected]>
> Signed-off-by: Minghao Chi <[email protected]>
> ---
> drivers/net/wireless/silabs/wfx/fwio.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/silabs/wfx/fwio.c b/drivers/net/wireless/silabs/wfx/fwio.c
> index 3d1b8a135dc0..52c7f560b062 100644
> --- a/drivers/net/wireless/silabs/wfx/fwio.c
> +++ b/drivers/net/wireless/silabs/wfx/fwio.c
> @@ -286,8 +286,7 @@ static int load_firmware_secure(struct wfx_dev *wdev)
>
> error:
> kfree(buf);
> - if (fw)
> - release_firmware(fw);
> + release_firmware(fw);
> if (ret)
> print_boot_status(wdev);
> return ret;
> --
> 2.25.1

Signed-off-by: J?r?me Pouiller <[email protected]>

--
J?r?me Pouiller

2022-06-08 09:22:09

by Kalle Valo

Subject: Re: [PATCH] staging: wfx: Remove redundant NULL check before release_firmware() call

Jérôme Pouiller <[email protected]> writes:

> On Monday 6 June 2022 03:42:37 CEST [email protected] wrote:
>> From: Minghao Chi <[email protected]>
>>
>> release_firmware() checks for NULL pointers internally so checking
>> before calling it is redundant.
>>
>> Reported-by: Zeal Robot <[email protected]>
>> Signed-off-by: Minghao Chi <[email protected]>

[...]

> Signed-off-by: Jérôme Pouiller <[email protected]>

I'll change this to Acked-by, s-o-b should be used only when you are
part of patch distribution:

https://www.kernel.org/doc/html/latest/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-by

And please edit your quotes, otherwise using patchwork will be painful.

--
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

2022-06-10 07:53:12

by Kalle Valo

Subject: Re: wifi: wfx: Remove redundant NULL check before release_firmware() call

[email protected] wrote:

> From: Minghao Chi <[email protected]>
>
> release_firmware() checks for NULL pointers internally so checking
> before calling it is redundant.
>
> Reported-by: Zeal Robot <[email protected]>
> Signed-off-by: Minghao Chi <[email protected]>
> Acked-by: Jérôme Pouiller <[email protected]>

Patch applied to wireless-next.git, thanks.

05a2eebfa650 wifi: wfx: Remove redundant NULL check before release_firmware() call

--
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches