2023-01-18 18:01:58

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH] dt-bindings: net: wireless: minor whitespace and name cleanups

Minor cleanups:
- Drop redundant blank lines,
- Correct indentaion in examples,
- Correct node names in examples to drop underscore and use generic
name.

No functional impact except adjusting to preferred coding style.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
.../bindings/net/wireless/esp,esp8089.yaml | 20 +++---
.../bindings/net/wireless/ieee80211.yaml | 1 -
.../bindings/net/wireless/mediatek,mt76.yaml | 1 -
.../bindings/net/wireless/qcom,ath11k.yaml | 11 ++-
.../bindings/net/wireless/silabs,wfx.yaml | 1 -
.../bindings/net/wireless/ti,wlcore.yaml | 70 +++++++++----------
6 files changed, 50 insertions(+), 54 deletions(-)

diff --git a/Documentation/devicetree/bindings/net/wireless/esp,esp8089.yaml b/Documentation/devicetree/bindings/net/wireless/esp,esp8089.yaml
index 5557676e9d4b..0ea84d6fe73e 100644
--- a/Documentation/devicetree/bindings/net/wireless/esp,esp8089.yaml
+++ b/Documentation/devicetree/bindings/net/wireless/esp,esp8089.yaml
@@ -29,15 +29,15 @@ additionalProperties: false

examples:
- |
- mmc {
- #address-cells = <1>;
- #size-cells = <0>;
-
- [email protected] {
- compatible = "esp,esp8089";
- reg = <1>;
- esp,crystal-26M-en = <2>;
- };
- };
+ mmc {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ [email protected] {
+ compatible = "esp,esp8089";
+ reg = <1>;
+ esp,crystal-26M-en = <2>;
+ };
+ };

...
diff --git a/Documentation/devicetree/bindings/net/wireless/ieee80211.yaml b/Documentation/devicetree/bindings/net/wireless/ieee80211.yaml
index e68ed9423150..d89f7a3f88a7 100644
--- a/Documentation/devicetree/bindings/net/wireless/ieee80211.yaml
+++ b/Documentation/devicetree/bindings/net/wireless/ieee80211.yaml
@@ -1,6 +1,5 @@
# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
# Copyright (c) 2018-2019 The Linux Foundation. All rights reserved.
-
%YAML 1.2
---
$id: http://devicetree.org/schemas/net/wireless/ieee80211.yaml#
diff --git a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
index f0c78f994491..7d526ff53fb7 100644
--- a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
+++ b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
@@ -1,6 +1,5 @@
# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
# Copyright (c) 2018-2019 The Linux Foundation. All rights reserved.
-
%YAML 1.2
---
$id: http://devicetree.org/schemas/net/wireless/mediatek,mt76.yaml#
diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml b/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml
index 556eb523606a..5f4b141ba813 100644
--- a/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml
+++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml
@@ -1,6 +1,5 @@
# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
# Copyright (c) 2018-2019 The Linux Foundation. All rights reserved.
-
%YAML 1.2
---
$id: http://devicetree.org/schemas/net/wireless/qcom,ath11k.yaml#
@@ -262,10 +261,10 @@ allOf:
examples:
- |

- q6v5_wcss: [email protected] {
+ q6v5_wcss: [email protected] {
compatible = "qcom,ipq8074-wcss-pil";
- reg = <0xCD00000 0x4040>,
- <0x4AB000 0x20>;
+ reg = <0xcd00000 0x4040>,
+ <0x4ab000 0x20>;
reg-names = "qdsp6",
"rmb";
};
@@ -386,7 +385,7 @@ examples:
#address-cells = <2>;
#size-cells = <2>;

- qcn9074_0: [email protected] {
+ qcn9074_0: [email protected] {
no-map;
reg = <0x0 0x51100000 0x0 0x03500000>;
};
@@ -463,6 +462,6 @@ examples:
qcom,smem-states = <&wlan_smp2p_out 0>;
qcom,smem-state-names = "wlan-smp2p-out";
wifi-firmware {
- iommus = <&apps_smmu 0x1c02 0x1>;
+ iommus = <&apps_smmu 0x1c02 0x1>;
};
};
diff --git a/Documentation/devicetree/bindings/net/wireless/silabs,wfx.yaml b/Documentation/devicetree/bindings/net/wireless/silabs,wfx.yaml
index 583db5d42226..84e5659e50ef 100644
--- a/Documentation/devicetree/bindings/net/wireless/silabs,wfx.yaml
+++ b/Documentation/devicetree/bindings/net/wireless/silabs,wfx.yaml
@@ -2,7 +2,6 @@
# Copyright (c) 2020, Silicon Laboratories, Inc.
%YAML 1.2
---
-
$id: http://devicetree.org/schemas/net/wireless/silabs,wfx.yaml#
$schema: http://devicetree.org/meta-schemas/core.yaml#

diff --git a/Documentation/devicetree/bindings/net/wireless/ti,wlcore.yaml b/Documentation/devicetree/bindings/net/wireless/ti,wlcore.yaml
index e31456730e9f..f799a1e52173 100644
--- a/Documentation/devicetree/bindings/net/wireless/ti,wlcore.yaml
+++ b/Documentation/devicetree/bindings/net/wireless/ti,wlcore.yaml
@@ -90,47 +90,47 @@ examples:

// For wl12xx family:
spi1 {
- #address-cells = <1>;
- #size-cells = <0>;
-
- wlcore1: [email protected] {
- compatible = "ti,wl1271";
- reg = <1>;
- spi-max-frequency = <48000000>;
- interrupts = <8 IRQ_TYPE_LEVEL_HIGH>;
- vwlan-supply = <&vwlan_fixed>;
- clock-xtal;
- ref-clock-frequency = <38400000>;
- };
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ wlcore1: [email protected] {
+ compatible = "ti,wl1271";
+ reg = <1>;
+ spi-max-frequency = <48000000>;
+ interrupts = <8 IRQ_TYPE_LEVEL_HIGH>;
+ vwlan-supply = <&vwlan_fixed>;
+ clock-xtal;
+ ref-clock-frequency = <38400000>;
+ };
};

// For wl18xx family:
spi2 {
- #address-cells = <1>;
- #size-cells = <0>;
-
- wlcore2: [email protected] {
- compatible = "ti,wl1835";
- reg = <0>;
- spi-max-frequency = <48000000>;
- interrupts = <27 IRQ_TYPE_EDGE_RISING>;
- vwlan-supply = <&vwlan_fixed>;
- };
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ wlcore2: [email protected] {
+ compatible = "ti,wl1835";
+ reg = <0>;
+ spi-max-frequency = <48000000>;
+ interrupts = <27 IRQ_TYPE_EDGE_RISING>;
+ vwlan-supply = <&vwlan_fixed>;
+ };
};

// SDIO example:
mmc3 {
- vmmc-supply = <&wlan_en_reg>;
- bus-width = <4>;
- cap-power-off-card;
- keep-power-in-suspend;
-
- #address-cells = <1>;
- #size-cells = <0>;
-
- wlcore3: [email protected] {
- compatible = "ti,wl1835";
- reg = <2>;
- interrupts = <19 IRQ_TYPE_LEVEL_HIGH>;
- };
+ vmmc-supply = <&wlan_en_reg>;
+ bus-width = <4>;
+ cap-power-off-card;
+ keep-power-in-suspend;
+
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ wlcore3: [email protected] {
+ compatible = "ti,wl1835";
+ reg = <2>;
+ interrupts = <19 IRQ_TYPE_LEVEL_HIGH>;
+ };
};
--
2.34.1


2023-01-19 07:41:47

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: net: wireless: minor whitespace and name cleanups

On 19/01/2023 06:13, Kalle Valo wrote:
> Krzysztof Kozlowski <[email protected]> writes:
>
>> Minor cleanups:
>> - Drop redundant blank lines,
>> - Correct indentaion in examples,
>> - Correct node names in examples to drop underscore and use generic
>> name.
>>
>> No functional impact except adjusting to preferred coding style.
>>
>> Signed-off-by: Krzysztof Kozlowski <[email protected]>
>> ---
>> .../bindings/net/wireless/esp,esp8089.yaml | 20 +++---
>> .../bindings/net/wireless/ieee80211.yaml | 1 -
>> .../bindings/net/wireless/mediatek,mt76.yaml | 1 -
>> .../bindings/net/wireless/qcom,ath11k.yaml | 11 ++-
>> .../bindings/net/wireless/silabs,wfx.yaml | 1 -
>> .../bindings/net/wireless/ti,wlcore.yaml | 70 +++++++++----------
>> 6 files changed, 50 insertions(+), 54 deletions(-)
>
> Thanks for the cleanup. Would you like to me to take this to
> wireless-next or do you have other plans?

Go ahead and grab it for wireless-next, please. Thanks!

Best regards,
Krzysztof

2023-01-20 04:51:26

by Kalle Valo

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: net: wireless: minor whitespace and name cleanups

Krzysztof Kozlowski <[email protected]> writes:

> Minor cleanups:
> - Drop redundant blank lines,
> - Correct indentaion in examples,
> - Correct node names in examples to drop underscore and use generic
> name.
>
> No functional impact except adjusting to preferred coding style.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> .../bindings/net/wireless/esp,esp8089.yaml | 20 +++---
> .../bindings/net/wireless/ieee80211.yaml | 1 -
> .../bindings/net/wireless/mediatek,mt76.yaml | 1 -
> .../bindings/net/wireless/qcom,ath11k.yaml | 11 ++-
> .../bindings/net/wireless/silabs,wfx.yaml | 1 -
> .../bindings/net/wireless/ti,wlcore.yaml | 70 +++++++++----------
> 6 files changed, 50 insertions(+), 54 deletions(-)

Thanks for the cleanup. Would you like to me to take this to
wireless-next or do you have other plans?

--
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches