2023-10-19 15:33:15

by Johan Hovold

[permalink] [raw]
Subject: [PATCH v2 0/2] wifi: ath11k: fix event locking

RCU lockdep reported suspicious RCU usage when accessing the temperature
sensor. Inspection revealed that the DFS radar event code was also
missing the required RCU read-side critical section marking.

Johan


Changes in v2
- add the missing rcu_read_unlock() to an
ath11k_wmi_pdev_temperature_event() error path as noticed by Jeff


Johan Hovold (2):
wifi: ath11k: fix temperature event locking
wifi: ath11k: fix dfs radar event locking

drivers/net/wireless/ath/ath11k/wmi.c | 11 +++++++++--
1 file changed, 9 insertions(+), 2 deletions(-)

--
2.41.0


2023-10-24 14:08:00

by Kalle Valo

[permalink] [raw]
Subject: Re: [PATCH v2 0/2] wifi: ath11k: fix event locking

Johan Hovold <[email protected]> writes:

> RCU lockdep reported suspicious RCU usage when accessing the temperature
> sensor. Inspection revealed that the DFS radar event code was also
> missing the required RCU read-side critical section marking.
>
> Johan
>
>
> Changes in v2
> - add the missing rcu_read_unlock() to an
> ath11k_wmi_pdev_temperature_event() error path as noticed by Jeff
>
>
> Johan Hovold (2):
> wifi: ath11k: fix temperature event locking
> wifi: ath11k: fix dfs radar event locking

Thanks for the fixes. I really like using lockdep_assert_held() to
document if a function requires some lock held, is there anything
similar for RCU?

--
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches