2013-03-09 16:02:35

by Paul Bolle

Subject: [PATCH] sunrpc: drop "select NETVM"

The Kconfig entry for SUNRPC_SWAP selects NETVM. That select statement
was added in commit a564b8f0398636ba30b07c0eaebdef7ff7837249 ("nfs:
enable swap on NFS"). But there's no Kconfig symbol NETVM. It apparently
was only in used in development versions of the swap over nfs
functionality but never entered mainline. Anyhow, it is a nop and can
safely be dropped.

Signed-off-by: Paul Bolle <[email protected]>
---
net/sunrpc/Kconfig | 1 -
1 file changed, 1 deletion(-)

diff --git a/net/sunrpc/Kconfig b/net/sunrpc/Kconfig
index 516fe2c..262caf0 100644
--- a/net/sunrpc/Kconfig
+++ b/net/sunrpc/Kconfig
@@ -24,7 +24,6 @@ config SUNRPC_XPRT_RDMA
config SUNRPC_SWAP
bool
depends on SUNRPC
- select NETVM

config RPCSEC_GSS_KRB5
tristate "Secure RPC: Kerberos V mechanism"
--
1.7.11.7

2013-03-09 17:51:26

by J. Bruce Fields

Subject: Re: [PATCH] sunrpc: drop "select NETVM"

ACK.

On Sat, Mar 09, 2013 at 05:02:31PM +0100, Paul Bolle wrote:
> The Kconfig entry for SUNRPC_SWAP selects NETVM. That select statement
> was added in commit a564b8f0398636ba30b07c0eaebdef7ff7837249 ("nfs:
> enable swap on NFS").

Cc'ing Mel Gorman just in case there was something else going on there.

--b.

> But there's no Kconfig symbol NETVM. It apparently
> was only in used in development versions of the swap over nfs
> functionality but never entered mainline. Anyhow, it is a nop and can
> safely be dropped.
>
> Signed-off-by: Paul Bolle <[email protected]>
> ---
> net/sunrpc/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/net/sunrpc/Kconfig b/net/sunrpc/Kconfig
> index 516fe2c..262caf0 100644
> --- a/net/sunrpc/Kconfig
> +++ b/net/sunrpc/Kconfig
> @@ -24,7 +24,6 @@ config SUNRPC_XPRT_RDMA
> config SUNRPC_SWAP
> bool
> depends on SUNRPC
> - select NETVM
>
> config RPCSEC_GSS_KRB5
> tristate "Secure RPC: Kerberos V mechanism"
> --
> 1.7.11.7
>

2013-03-13 10:08:23

by Mel Gorman

Subject: Re: [PATCH] sunrpc: drop "select NETVM"

On Sat, Mar 09, 2013 at 12:51:18PM -0500, J. Bruce Fields wrote:
> ACK.
>
> On Sat, Mar 09, 2013 at 05:02:31PM +0100, Paul Bolle wrote:
> > The Kconfig entry for SUNRPC_SWAP selects NETVM. That select statement
> > was added in commit a564b8f0398636ba30b07c0eaebdef7ff7837249 ("nfs:
> > enable swap on NFS").
>
> Cc'ing Mel Gorman just in case there was something else going on there.
>
> --b.
>
> > But there's no Kconfig symbol NETVM. It apparently
> > was only in used in development versions of the swap over nfs
> > functionality but never entered mainline. Anyhow, it is a nop and can
> > safely be dropped.
> >

Correct, the NETVM symbol existed in an early version of swap-over-nfs
that I failed to clean up properly. Thanks.

--
Mel Gorman
SUSE Labs