2013-03-13 08:34:30

by Samuel Ortiz

[permalink] [raw]
Subject: Re: mfd: omap-usb-host: bug fix for 3.9

Hi Roger,

On Wed, Feb 27, 2013 at 04:02:53PM +0200, Roger Quadros wrote:
> Hi Samuel,
>
> One of my patch that I sent for 3.9 introduces a bug that fails to
> update the port mode hostconfig register. Because of that, the port modes will
> always be 0 (i.e. EHCI PHY mode) and other modes will not work. PHY mode will
> work, so beagle/panda have no issues.
>
> Since my hardware setup uses only PHY mode, I couldn't catch this problem earlier.
>
> Below is the fix.
>
> From 82466757a212bd8b54d806c9d56b1acccbd4d464 Mon Sep 17 00:00:00 2001
> From: Roger Quadros <[email protected]>
> Date: Wed, 27 Feb 2013 15:19:24 +0200
> Subject: [PATCH] mfd: omap-usb-host: Actually update hostconfig
>
> The helper functions omap_usbhs_rev1_hostconfig()
> and omap_usbhs_rev2_hostconfig() don't write into
> the hostconfig register. Make sure that we write
> the return value into the hostconfig register.
>
> Signed-off-by: Roger Quadros <[email protected]>
> ---
> drivers/mfd/omap-usb-host.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
Patch applied now, thanks.

Cheers,
Samuel.

--
Intel Open Source Technology Centre
http://oss.intel.com/