2013-03-18 09:15:15

by Ashish Jangam

Subject: [patch v1] mfd: da9055 change irq state to default

This patch changes the irq state from high to the now default low.
Because the default PMIC irq state of DA9055 got changed from high to low.
This change should not affect any of the existing users since all of them
use active low state.

This patch has been tested on smdkv6410.

Signed-off-by: Ashish <[email protected]>

---
drivers/mfd/da9055-core.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/mfd/da9055-core.c b/drivers/mfd/da9055-core.c
index f56a1a9..49cb23d 100644
--- a/drivers/mfd/da9055-core.c
+++ b/drivers/mfd/da9055-core.c
@@ -391,7 +391,7 @@ int da9055_device_init(struct da9055 *da9055)
da9055->irq_base = pdata->irq_base;

ret = regmap_add_irq_chip(da9055->regmap, da9055->chip_irq,
- IRQF_TRIGGER_HIGH | IRQF_ONESHOT,
+ IRQF_TRIGGER_LOW | IRQF_ONESHOT,
da9055->irq_base, &da9055_regmap_irq_chip,
&da9055->irq_data);
if (ret < 0)
--
1.7.1

2013-03-27 07:33:57

by Ashish Jangam

Subject: Re: [patch v1] mfd: da9055 change irq state to default

On Mon, 2013-03-18 at 14:42 +0530, Ashish Jangam wrote:
> This patch changes the irq state from high to the now default low.
> Because the default PMIC irq state of DA9055 got changed from high to low.
> This change should not affect any of the existing users since all of them
> use active low state.
>
> This patch has been tested on smdkv6410.
>
> Signed-off-by: Ashish <[email protected]>
>
> ---
> drivers/mfd/da9055-core.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mfd/da9055-core.c b/drivers/mfd/da9055-core.c
> index f56a1a9..49cb23d 100644
> --- a/drivers/mfd/da9055-core.c
> +++ b/drivers/mfd/da9055-core.c
> @@ -391,7 +391,7 @@ int da9055_device_init(struct da9055 *da9055)
> da9055->irq_base = pdata->irq_base;
>
> ret = regmap_add_irq_chip(da9055->regmap, da9055->chip_irq,
> - IRQF_TRIGGER_HIGH | IRQF_ONESHOT,
> + IRQF_TRIGGER_LOW | IRQF_ONESHOT,
> da9055->irq_base, &da9055_regmap_irq_chip,
> &da9055->irq_data);
> if (ret < 0)
If there are no comments then can this patch get merged.

2013-04-09 08:10:35

by Samuel Ortiz

Subject: Re: [patch v1] mfd: da9055 change irq state to default

Hi Ashish,

On Mon, Mar 18, 2013 at 02:42:38PM +0530, Ashish Jangam wrote:
> This patch changes the irq state from high to the now default low.
> Because the default PMIC irq state of DA9055 got changed from high to low.
> This change should not affect any of the existing users since all of them
> use active low state.
>
> This patch has been tested on smdkv6410.
>
> Signed-off-by: Ashish <[email protected]>
>
> ---
> drivers/mfd/da9055-core.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
Applied, thanks.

Cheers,
Samuel.

--
Intel Open Source Technology Centre
http://oss.intel.com/