2013-03-24 16:31:51

by Stefan Richter

[permalink] [raw]
Subject: [PATCH] firewire: sbp2: replace BUG_ON by WARN_ON

No need to crash and burn if S/G element sizes cannot be set to our
liking; just leave a message in the log.

Signed-off-by: Stefan Richter <[email protected]>
---
drivers/firewire/sbp2.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

--- a/drivers/firewire/sbp2.c
+++ b/drivers/firewire/sbp2.c
@@ -1144,8 +1144,8 @@ static int sbp2_probe(struct device *dev
return -ENODEV;

if (dma_get_max_seg_size(device->card->device) > SBP2_MAX_SEG_SIZE)
- BUG_ON(dma_set_max_seg_size(device->card->device,
- SBP2_MAX_SEG_SIZE));
+ WARN_ON(dma_set_max_seg_size(device->card->device,
+ SBP2_MAX_SEG_SIZE));

shost = scsi_host_alloc(&scsi_driver_template, sizeof(*tgt));
if (shost == NULL)


--
Stefan Richter
-=====-===-= --== ==---
http://arcgraph.de/sr/