2013-04-09 05:20:44

by Dan Carpenter

Subject: [patch] tty: mxser: forever loops on error

There were a couple signedness bugs decrementing "i" which would lead to
a forever loops.

I've made a couple other variables signed as well because they are all
related array offsets and it would be weird if they weren't the same
type.

Signed-off-by: Dan Carpenter <[email protected]>

diff --git a/drivers/tty/mxser.c b/drivers/tty/mxser.c
index d996038..a095859 100644
--- a/drivers/tty/mxser.c
+++ b/drivers/tty/mxser.c
@@ -2556,9 +2556,9 @@ static int mxser_probe(struct pci_dev *pdev,
{
#ifdef CONFIG_PCI
struct mxser_board *brd;
- unsigned int i, j;
unsigned long ioaddress;
struct device *tty_dev;
+ int i, j;
int retval = -EINVAL;

for (i = 0; i < MXSER_BOARDS; i++)
@@ -2700,7 +2700,7 @@ static int __init mxser_module_init(void)
{
struct mxser_board *brd;
struct device *tty_dev;
- unsigned int b, i, m;
+ int b, i, m;
int retval;

mxvar_sdriver = alloc_tty_driver(MXSER_PORTS + 1);

2013-04-09 05:51:06

by Alexey Khoroshilov

Subject: Re: [patch] tty: mxser: forever loops on error

Hi Dan,

Thank you for the patch.

We are also trying to fix the issue:
https://lkml.org/lkml/2013/2/19/29
https://lkml.org/lkml/2013/4/8/55

and the fix is finally in Greg's tty git tree since yesterday:
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git
(tty-linus branch).

Best regards,
Alexey


On 04/09/2013 09:18 AM, Dan Carpenter wrote:
> There were a couple signedness bugs decrementing "i" which would lead to
> a forever loops.
>
> I've made a couple other variables signed as well because they are all
> related array offsets and it would be weird if they weren't the same
> type.
>
> Signed-off-by: Dan Carpenter <[email protected]>
>
> diff --git a/drivers/tty/mxser.c b/drivers/tty/mxser.c
> index d996038..a095859 100644
> --- a/drivers/tty/mxser.c
> +++ b/drivers/tty/mxser.c
> @@ -2556,9 +2556,9 @@ static int mxser_probe(struct pci_dev *pdev,
> {
> #ifdef CONFIG_PCI
> struct mxser_board *brd;
> - unsigned int i, j;
> unsigned long ioaddress;
> struct device *tty_dev;
> + int i, j;
> int retval = -EINVAL;
>
> for (i = 0; i < MXSER_BOARDS; i++)
> @@ -2700,7 +2700,7 @@ static int __init mxser_module_init(void)
> {
> struct mxser_board *brd;
> struct device *tty_dev;
> - unsigned int b, i, m;
> + int b, i, m;
> int retval;
>
> mxvar_sdriver = alloc_tty_driver(MXSER_PORTS + 1);
>

2013-04-09 06:22:42

by Dan Carpenter

Subject: Re: [patch] tty: mxser: forever loops on error

On Tue, Apr 09, 2013 at 09:50:35AM +0400, Alexey Khoroshilov wrote:
> Hi Dan,
>
> Thank you for the patch.
>
> We are also trying to fix the issue:
> https://lkml.org/lkml/2013/2/19/29
> https://lkml.org/lkml/2013/4/8/55
>
> and the fix is finally in Greg's tty git tree since yesterday:
> git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git
> (tty-linus branch).
>

Good deal.

Btw, by the time that Fenguang's kbuild scripts emailed you, it was
already too late to send a v2 patch.

regards,
dan carpenter