2002-09-29 23:06:47

by Phil Oester

[permalink] [raw]
Subject: [PATCH] 2.5.39 - make MCE options arch dependent

No need to see P4 or Athlon options if you don't have one...

-Phil


--- linux-2.5.39-orig/arch/i386/config.in Fri Sep 27 14:49:42 2002
+++ linux-2.5.39/arch/i386/config.in Sun Sep 29 15:55:44 2002
@@ -187,8 +187,12 @@
fi

bool 'Machine Check Exception' CONFIG_X86_MCE
-dep_bool 'Check for non-fatal errors on Athlon/Duron' CONFIG_X86_MCE_NONFATAL $CONFIG_X86_MCE
-dep_bool 'check for P4 thermal throttling interrupt.' CONFIG_X86_MCE_P4THERMAL $CONFIG_X86_MCE $CONFIG_X86_UP_APIC
+if [ "$CONFIG_MK7" = "y" ]; then
+ dep_bool 'Check for non-fatal errors on Athlon/Duron' CONFIG_X86_MCE_NONFATAL $CONFIG_X86_MCE
+fi
+if [ "$CONFIG_MPENTIUM4" = "y" ]; then
+ dep_bool 'Check for P4 thermal throttling interrupt' CONFIG_X86_MCE_P4THERMAL $CONFIG_X86_MCE $CONFIG_X86_UP_APIC
+fi


2002-09-29 23:11:11

by Dave Jones

[permalink] [raw]
Subject: Re: [PATCH] 2.5.39 - make MCE options arch dependent

On Sun, Sep 29, 2002 at 04:12:06PM -0700, Phil Oester wrote:
> No need to see P4 or Athlon options if you don't have one...
>
> -Phil

Broken. Vendor kernels compile for 386, but include both these
options, so the same kernel can run on P4/Athlon and use
these options.

Dave

--
| Dave Jones. http://www.codemonkey.org.uk
| SuSE Labs

2002-09-29 23:20:19

by Richard Gooch

[permalink] [raw]
Subject: Re: [PATCH] 2.5.39 - make MCE options arch dependent

Phil Oester writes:
> No need to see P4 or Athlon options if you don't have one...
>
> --- linux-2.5.39-orig/arch/i386/config.in Fri Sep 27 14:49:42 2002
> +++ linux-2.5.39/arch/i386/config.in Sun Sep 29 15:55:44 2002
> @@ -187,8 +187,12 @@
> fi
>
> bool 'Machine Check Exception' CONFIG_X86_MCE
> -dep_bool 'Check for non-fatal errors on Athlon/Duron' CONFIG_X86_MCE_NONFATAL $CONFIG_X86_MCE
> -dep_bool 'check for P4 thermal throttling interrupt.' CONFIG_X86_MCE_P4THERMAL $CONFIG_X86_MCE $CONFIG_X86_UP_APIC
> +if [ "$CONFIG_MK7" = "y" ]; then
> + dep_bool 'Check for non-fatal errors on Athlon/Duron' CONFIG_X86_MCE_NONFATAL $CONFIG_X86_MCE
> +fi
> +if [ "$CONFIG_MPENTIUM4" = "y" ]; then
> + dep_bool 'Check for P4 thermal throttling interrupt' CONFIG_X86_MCE_P4THERMAL $CONFIG_X86_MCE $CONFIG_X86_UP_APIC
> +fi

But now I can't build a "generic" kernel which supports both these
features.

Regards,

Richard....
Permanent: [email protected]
Current: [email protected]

2002-09-30 12:51:06

by Alan Cox

[permalink] [raw]
Subject: Re: [PATCH] 2.5.39 - make MCE options arch dependent

On Mon, 2002-09-30 at 00:12, Phil Oester wrote:
> No need to see P4 or Athlon options if you don't have one..

This makes little sense. The P4 and K7 MCE handling can be built into
any kernel tree and will correctly work. That means you can build things
into a generic kernel not just a per processor kernel, which for any
number of systems becomes unmanagable