2013-05-27 14:04:16

by Rabin Vincent

Subject: [PATCH] dmaengine: ste_dma40: fix pm runtime ref counting

The pm runtime reference counting of the driver is broken for the case
when there is more than one transfer queued, leading to the device being
runtime suspend while active. Fix it.

Signed-off-by: Rabin Vincent <[email protected]>
---
drivers/dma/ste_dma40.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/drivers/dma/ste_dma40.c b/drivers/dma/ste_dma40.c
index 1734fee..71bf4ec 100644
--- a/drivers/dma/ste_dma40.c
+++ b/drivers/dma/ste_dma40.c
@@ -1566,10 +1566,12 @@ static void dma_tc_handle(struct d40_chan *d40c)
return;
}

- if (d40_queue_start(d40c) == NULL)
+ if (d40_queue_start(d40c) == NULL) {
d40c->busy = false;
- pm_runtime_mark_last_busy(d40c->base->dev);
- pm_runtime_put_autosuspend(d40c->base->dev);
+
+ pm_runtime_mark_last_busy(d40c->base->dev);
+ pm_runtime_put_autosuspend(d40c->base->dev);
+ }

d40_desc_remove(d40d);
d40_desc_done(d40c, d40d);
--
1.8.1.5

2013-05-27 14:05:59

by Linus Walleij

Subject: Re: [PATCH] dmaengine: ste_dma40: fix pm runtime ref counting

On Mon, May 27, 2013 at 4:03 PM, Rabin Vincent
<[email protected]> wrote:

> The pm runtime reference counting of the driver is broken for the case
> when there is more than one transfer queued, leading to the device being
> runtime suspend while active. Fix it.
>
> Signed-off-by: Rabin Vincent <[email protected]>

Looks good to me.
Acked-by: Linus Walleij <[email protected]>

Vinod, are you taking this for fixes?

Yours,
Linus Walleij

2013-05-27 15:02:37

by Vinod Koul

Subject: Re: [PATCH] dmaengine: ste_dma40: fix pm runtime ref counting

On Mon, May 27, 2013 at 04:05:57PM +0200, Linus Walleij wrote:
> On Mon, May 27, 2013 at 4:03 PM, Rabin Vincent
> <[email protected]> wrote:
>
> > The pm runtime reference counting of the driver is broken for the case
> > when there is more than one transfer queued, leading to the device being
> > runtime suspend while active. Fix it.
> >
> > Signed-off-by: Rabin Vincent <[email protected]>
>
> Looks good to me.
> Acked-by: Linus Walleij <[email protected]>
>
> Vinod, are you taking this for fixes?
Sure, applied to fixes. CCed stable as well

--
~Vinod