2013-05-31 21:22:02

by Suman Anna

Subject: [PATCH 2/3] remoteproc/omap: fix a sparse warning

This patch fixes a sparse warning in the omap remoteproc code
when OMAP_REMOTEPROC is disabled.

include/linux/platform_data/remoteproc-omap.h:76:13: warning: symbol 'omap_rproc_reserve_cma' was not declared. Should it be static?

Signed-off-by: Suman Anna <[email protected]>
---
include/linux/platform_data/remoteproc-omap.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/platform_data/remoteproc-omap.h b/include/linux/platform_data/remoteproc-omap.h
index 3c1c644..bfbd12b 100644
--- a/include/linux/platform_data/remoteproc-omap.h
+++ b/include/linux/platform_data/remoteproc-omap.h
@@ -50,7 +50,7 @@ void __init omap_rproc_reserve_cma(void);

#else

-void __init omap_rproc_reserve_cma(void)
+static inline void __init omap_rproc_reserve_cma(void)
{
}

--
1.8.2

2013-07-01 14:17:40

by Ohad Ben Cohen

Subject: Re: [PATCH 2/3] remoteproc/omap: fix a sparse warning

On Sat, Jun 1, 2013 at 12:16 AM, Suman Anna <[email protected]> wrote:
> This patch fixes a sparse warning in the omap remoteproc code
> when OMAP_REMOTEPROC is disabled.
>
> include/linux/platform_data/remoteproc-omap.h:76:13: warning: symbol 'omap_rproc_reserve_cma' was not declared. Should it be static?
>
> Signed-off-by: Suman Anna <[email protected]>

Applied, thanks