2013-06-01 10:08:58

by Thomas Meyer

[permalink] [raw]

Subject: [PATCH] usb: gadget: Cocci spatch "err_cast.spatch"

---

Signed-off-by: Thomas Meyer <[email protected]>
---

diff -u -p a/drivers/usb/gadget/composite.c b/drivers/usb/gadget/composite.c
--- a/drivers/usb/gadget/composite.c
+++ b/drivers/usb/gadget/composite.c
@@ -1138,7 +1138,7 @@ struct usb_string *usb_gstrings_attach(s

uc = copy_gadget_strings(sp, n_gstrings, n_strings);
if (IS_ERR(uc))
- return ERR_PTR(PTR_ERR(uc));
+ return ERR_CAST(uc);

n_gs = get_containers_gs(uc);
ret = usb_string_ids_tab(cdev, n_gs[0]->strings);

diff -u -p a/drivers/usb/gadget/configfs.c b/drivers/usb/gadget/configfs.c
--- a/drivers/usb/gadget/configfs.c
+++ b/drivers/usb/gadget/configfs.c
@@ -557,7 +557,7 @@ static struct config_group *function_mak

fi = usb_get_function_instance(func_name);
if (IS_ERR(fi))
- return ERR_PTR(PTR_ERR(fi));
+ return ERR_CAST(fi);

ret = config_item_set_name(&fi->group.cg_item, name);
if (ret) {

2013-06-01 17:00:34

by Felipe Balbi

[permalink] [raw]

Subject: Re: [PATCH] usb: gadget: Cocci spatch "err_cast.spatch"

---

On Sat, Jun 01, 2013 at 12:08:45PM +0200, Thomas Meyer wrote:
>

-ENOLOG

> Signed-off-by: Thomas Meyer <[email protected]>
> ---
>
> diff -u -p a/drivers/usb/gadget/composite.c b/drivers/usb/gadget/composite.c
> --- a/drivers/usb/gadget/composite.c
> +++ b/drivers/usb/gadget/composite.c
> @@ -1138,7 +1138,7 @@ struct usb_string *usb_gstrings_attach(s
>
> uc = copy_gadget_strings(sp, n_gstrings, n_strings);
> if (IS_ERR(uc))
> - return ERR_PTR(PTR_ERR(uc));
> + return ERR_CAST(uc);
>
> n_gs = get_containers_gs(uc);
> ret = usb_string_ids_tab(cdev, n_gs[0]->strings);
>
> diff -u -p a/drivers/usb/gadget/configfs.c b/drivers/usb/gadget/configfs.c
> --- a/drivers/usb/gadget/configfs.c
> +++ b/drivers/usb/gadget/configfs.c
> @@ -557,7 +557,7 @@ static struct config_group *function_mak
>
> fi = usb_get_function_instance(func_name);
> if (IS_ERR(fi))
> - return ERR_PTR(PTR_ERR(fi));
> + return ERR_CAST(fi);
>
> ret = config_item_set_name(&fi->group.cg_item, name);
> if (ret) {
>
>

--
balbi

---

Attachments:

(No filename) (1.01 kB)
signature.asc (836.00 B)
Digital signature Download all attachments