2013-06-03 11:00:28

by Ian Campbell

[permalink] [raw]
Subject: [PATCH] powerpc/4xx: Fix warning in kilauea.dtb

Currently I see:
DTC arch/powerpc/boot/kilauea.dtb
Warning (reg_format): "reg" property in /plb/ppc4xx-msi@C10000000 has invalid length (12 bytes) (#address-cells == 1, #size-cells == 1)

It appears that unlike the other plarforms handled by 3fb7933850fa
"powerpc/4xx: Adding PCIe MSI support" this platform does not use address-cells=2.

Signed-off-by: Ian Campbell <[email protected]>
Cc: Rupjyoti Sarmah <[email protected]>
Cc: Tirumala R Marri <[email protected]>
Cc: Josh Boyer <[email protected]>
Cc: Benjamin Herrenschmidt <[email protected]>
Cc: Paul Mackerras <[email protected]>
Cc: [email protected]
Cc: [email protected]
---
arch/powerpc/boot/dts/kilauea.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/boot/dts/kilauea.dts b/arch/powerpc/boot/dts/kilauea.dts
index 1613d6e..5ba7f01 100644
--- a/arch/powerpc/boot/dts/kilauea.dts
+++ b/arch/powerpc/boot/dts/kilauea.dts
@@ -406,7 +406,7 @@

MSI: ppc4xx-msi@C10000000 {
compatible = "amcc,ppc4xx-msi", "ppc4xx-msi";
- reg = < 0x0 0xEF620000 0x100>;
+ reg = <0xEF620000 0x100>;
sdr-base = <0x4B0>;
msi-data = <0x00000000>;
msi-mask = <0x44440000>;
--
1.7.10.4


2013-06-03 13:36:54

by Josh Boyer

[permalink] [raw]
Subject: Re: [PATCH] powerpc/4xx: Fix warning in kilauea.dtb

On Mon, Jun 03, 2013 at 12:00:24PM +0100, Ian Campbell wrote:
>Currently I see:
> DTC arch/powerpc/boot/kilauea.dtb
>Warning (reg_format): "reg" property in /plb/ppc4xx-msi@C10000000 has invalid length (12 bytes) (#address-cells == 1, #size-cells == 1)
>
>It appears that unlike the other plarforms handled by 3fb7933850fa
>"powerpc/4xx: Adding PCIe MSI support" this platform does not use address-cells=2.

Right, it's a 405, not a 440. I should have caught that in the initial
review.

>Signed-off-by: Ian Campbell <[email protected]>
>Cc: Rupjyoti Sarmah <[email protected]>
>Cc: Tirumala R Marri <[email protected]>
>Cc: Josh Boyer <[email protected]>

That address should bounce. It hasn't been active in almost 2 years.

>Cc: Benjamin Herrenschmidt <[email protected]>
>Cc: Paul Mackerras <[email protected]>
>Cc: [email protected]
>Cc: [email protected]

Acked-by: Josh Boyer <[email protected]>

>---
> arch/powerpc/boot/dts/kilauea.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/arch/powerpc/boot/dts/kilauea.dts b/arch/powerpc/boot/dts/kilauea.dts
>index 1613d6e..5ba7f01 100644
>--- a/arch/powerpc/boot/dts/kilauea.dts
>+++ b/arch/powerpc/boot/dts/kilauea.dts
>@@ -406,7 +406,7 @@
>
> MSI: ppc4xx-msi@C10000000 {
> compatible = "amcc,ppc4xx-msi", "ppc4xx-msi";
>- reg = < 0x0 0xEF620000 0x100>;
>+ reg = <0xEF620000 0x100>;
> sdr-base = <0x4B0>;
> msi-data = <0x00000000>;
> msi-mask = <0x44440000>;
>--
>1.7.10.4
>
>_______________________________________________
>Linuxppc-dev mailing list
>[email protected]
>https://lists.ozlabs.org/listinfo/linuxppc-dev

2013-06-03 13:49:13

by Ian Campbell

[permalink] [raw]
Subject: Re: [PATCH] powerpc/4xx: Fix warning in kilauea.dtb

On Mon, 2013-06-03 at 09:36 -0400, Josh Boyer wrote:
> On Mon, Jun 03, 2013 at 12:00:24PM +0100, Ian Campbell wrote:
> >Currently I see:
> > DTC arch/powerpc/boot/kilauea.dtb
> >Warning (reg_format): "reg" property in /plb/ppc4xx-msi@C10000000 has invalid length (12 bytes) (#address-cells == 1, #size-cells == 1)
> >
> >It appears that unlike the other plarforms handled by 3fb7933850fa
> >"powerpc/4xx: Adding PCIe MSI support" this platform does not use address-cells=2.
>
> Right, it's a 405, not a 440. I should have caught that in the initial
> review.
>
> >Signed-off-by: Ian Campbell <[email protected]>
> >Cc: Rupjyoti Sarmah <[email protected]>
> >Cc: Tirumala R Marri <[email protected]>
> >Cc: Josh Boyer <[email protected]>
>
> That address should bounce. It hasn't been active in almost 2 years.

Funnily enough the previous patch to this file (where I nabbed the
address from) was approximately that long ago ;-)

I've updated my local copy with your Ack with the correct address,
thanks.

I also corrected the "plarforms" typo which I just spotted...

Ian.

> >Cc: Benjamin Herrenschmidt <[email protected]>
> >Cc: Paul Mackerras <[email protected]>
> >Cc: [email protected]
> >Cc: [email protected]
>
> Acked-by: Josh Boyer <[email protected]>
>
> >---
> > arch/powerpc/boot/dts/kilauea.dts | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >diff --git a/arch/powerpc/boot/dts/kilauea.dts b/arch/powerpc/boot/dts/kilauea.dts
> >index 1613d6e..5ba7f01 100644
> >--- a/arch/powerpc/boot/dts/kilauea.dts
> >+++ b/arch/powerpc/boot/dts/kilauea.dts
> >@@ -406,7 +406,7 @@
> >
> > MSI: ppc4xx-msi@C10000000 {
> > compatible = "amcc,ppc4xx-msi", "ppc4xx-msi";
> >- reg = < 0x0 0xEF620000 0x100>;
> >+ reg = <0xEF620000 0x100>;
> > sdr-base = <0x4B0>;
> > msi-data = <0x00000000>;
> > msi-mask = <0x44440000>;
> >--
> >1.7.10.4
> >
> >_______________________________________________
> >Linuxppc-dev mailing list
> >[email protected]
> >https://lists.ozlabs.org/listinfo/linuxppc-dev

2013-09-24 09:10:50

by Ian Campbell

[permalink] [raw]
Subject: Re: [PATCH] powerpc/4xx: Fix warning in kilauea.dtb

On Mon, 2013-06-03 at 09:36 -0400, Josh Boyer wrote:
> On Mon, Jun 03, 2013 at 12:00:24PM +0100, Ian Campbell wrote:
> >Currently I see:
> > DTC arch/powerpc/boot/kilauea.dtb
> >Warning (reg_format): "reg" property in /plb/ppc4xx-msi@C10000000 has invalid length (12 bytes) (#address-cells == 1, #size-cells == 1)
> >
> >It appears that unlike the other plarforms handled by 3fb7933850fa
> >"powerpc/4xx: Adding PCIe MSI support" this platform does not use address-cells=2.
>
> Right, it's a 405, not a 440. I should have caught that in the initial
> review.
>
> >Signed-off-by: Ian Campbell <[email protected]>
> >Cc: Rupjyoti Sarmah <[email protected]>
> >Cc: Tirumala R Marri <[email protected]>
> >Cc: Josh Boyer <[email protected]>
>
> That address should bounce. It hasn't been active in almost 2 years.
>
> >Cc: Benjamin Herrenschmidt <[email protected]>
> >Cc: Paul Mackerras <[email protected]>
> >Cc: [email protected]
> >Cc: [email protected]
>
> Acked-by: Josh Boyer <[email protected]>

This still doesn't appear to be fixed v3.12-rc2. Ping?

>
> >---
> > arch/powerpc/boot/dts/kilauea.dts | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >diff --git a/arch/powerpc/boot/dts/kilauea.dts b/arch/powerpc/boot/dts/kilauea.dts
> >index 1613d6e..5ba7f01 100644
> >--- a/arch/powerpc/boot/dts/kilauea.dts
> >+++ b/arch/powerpc/boot/dts/kilauea.dts
> >@@ -406,7 +406,7 @@
> >
> > MSI: ppc4xx-msi@C10000000 {
> > compatible = "amcc,ppc4xx-msi", "ppc4xx-msi";
> >- reg = < 0x0 0xEF620000 0x100>;
> >+ reg = <0xEF620000 0x100>;
> > sdr-base = <0x4B0>;
> > msi-data = <0x00000000>;
> > msi-mask = <0x44440000>;
> >--
> >1.7.10.4
> >
> >_______________________________________________
> >Linuxppc-dev mailing list
> >[email protected]
> >https://lists.ozlabs.org/listinfo/linuxppc-dev