Hi Greg,
After merging the tty tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:
drivers/tty/n_tty.c: In function 'n_tty_close':
drivers/tty/n_tty.c:1757:2: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration]
vfree(ldata);
^
drivers/tty/n_tty.c: In function 'n_tty_open':
drivers/tty/n_tty.c:1776:2: error: implicit declaration of function 'vmalloc' [-Werror=implicit-function-declaration]
ldata = vmalloc(sizeof(*ldata));
^
drivers/tty/n_tty.c:1776:8: warning: assignment makes pointer from integer without a cast [enabled by default]
ldata = vmalloc(sizeof(*ldata));
^
Caused by commit 20bafb3d23d1 ("n_tty: Move buffers into n_tty_data").
Forgot to include linux/vmalloc.h?
I have used the tty tree from next-20130723 for today.
--
Cheers,
Stephen Rothwell [email protected]
http://www.canb.auug.org.au/~sfr/
On 07/24/2013 12:42 AM, Stephen Rothwell wrote:
> Hi Greg,
>
> After merging the tty tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
Sorry. Patch coming.
Regards,
Peter Hurley
Commit 20bafb3d23d108bc0a896eb8b7c1501f4f649b77
'n_tty: Move buffers into n_tty_data'
broke the ppc64 build.
Include vmalloc.h for the required function declarations.
Reported-by: Stephen Rothwell <[email protected]>
Signed-off-by: Peter Hurley <[email protected]>
---
drivers/tty/n_tty.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/tty/n_tty.c b/drivers/tty/n_tty.c
index d8cf96a..dd8ae0c 100644
--- a/drivers/tty/n_tty.c
+++ b/drivers/tty/n_tty.c
@@ -50,6 +50,7 @@
#include <linux/uaccess.h>
#include <linux/module.h>
#include <linux/ratelimit.h>
+#include <linux/vmalloc.h>
/* number of characters left in xmit buffer before select has we have room */
--
1.8.1.2