2013-08-09 03:17:39

by Kumar Gaurav

Subject: [PATCH]arch:avr32:kernel:time.c: Removed IRQF_DISABLED

Removed IRQF_DISABLED as it's no-op and should be removed

Signed-off-by: Kumar Gaurav <[email protected]>
---
arch/avr32/kernel/time.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/avr32/kernel/time.c b/arch/avr32/kernel/time.c
index 869a1c6..0566c81 100644
--- a/arch/avr32/kernel/time.c
+++ b/arch/avr32/kernel/time.c
@@ -59,7 +59,7 @@ static irqreturn_t timer_interrupt(int irq, void *dev_id)
static struct irqaction timer_irqaction = {
.handler = timer_interrupt,
/* Oprofile uses the same irq as the timer, so allow it to be shared */
- .flags = IRQF_TIMER | IRQF_DISABLED | IRQF_SHARED,
+ .flags = IRQF_TIMER | IRQF_TRIGGER_NONE | IRQF_SHARED,
.name = "avr32_comparator",
};

--
1.7.9.5

2013-08-09 03:19:29

by Kumar Gaurav

Subject: Re: [PATCH]arch:avr32:kernel:time.c: Removed IRQF_DISABLED

Please ignore the below patch. I'll be resending this with 0 instead of
IRQF_TRIGGER_NONE
On Friday 09 August 2013 08:47 AM, Kumar Gaurav wrote:
> Removed IRQF_DISABLED as it's no-op and should be removed
>
> Signed-off-by: Kumar Gaurav <[email protected]>
> ---
> arch/avr32/kernel/time.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/avr32/kernel/time.c b/arch/avr32/kernel/time.c
> index 869a1c6..0566c81 100644
> --- a/arch/avr32/kernel/time.c
> +++ b/arch/avr32/kernel/time.c
> @@ -59,7 +59,7 @@ static irqreturn_t timer_interrupt(int irq, void *dev_id)
> static struct irqaction timer_irqaction = {
> .handler = timer_interrupt,
> /* Oprofile uses the same irq as the timer, so allow it to be shared */
> - .flags = IRQF_TIMER | IRQF_DISABLED | IRQF_SHARED,
> + .flags = IRQF_TIMER | IRQF_TRIGGER_NONE | IRQF_SHARED,
> .name = "avr32_comparator",
> };
>

2013-08-09 03:30:41

by Joe Perches

Subject: Re: [PATCH]arch:avr32:kernel:time.c: Removed IRQF_DISABLED

On Fri, 2013-08-09 at 08:49 +0530, Kumar Gaurav wrote:
> Please ignore the below patch. I'll be resending this with 0 instead of
> IRQF_TRIGGER_NONE

Hey again Kumar.

This is one of those patches that should just have
IRQF_DISABLED completely elided.

> On Friday 09 August 2013 08:47 AM, Kumar Gaurav wrote:
[]
> > diff --git a/arch/avr32/kernel/time.c b/arch/avr32/kernel/time.c
[]
> > @@ -59,7 +59,7 @@ static irqreturn_t timer_interrupt(int irq, void *dev_id)
[]
> > - .flags = IRQF_TIMER | IRQF_DISABLED | IRQF_SHARED,
> > + .flags = IRQF_TIMER | IRQF_TRIGGER_NONE | IRQF_SHARED,

.flags = IRQF_TIMER | IRQF_SHARED,