2013-08-09 20:01:59

by Philippe De Swert

[permalink] [raw]
Subject: [PATCH] mmc: sdhci-pci : Remove logically dead code

The amount of slots is calculated as follows:
slots = PCI_SLOT_INFO_SLOTS(slots) + 1;

Which means that just after it slots cannot be 0.

Found with coverity: CID#744269

Signed-off-by: Philippe De Swert <[email protected]>
---
drivers/mmc/host/sdhci-pci.c | 3 ---
1 file changed, 3 deletions(-)

diff --git a/drivers/mmc/host/sdhci-pci.c b/drivers/mmc/host/sdhci-pci.c
index d7d6bc8..9c76558 100644
--- a/drivers/mmc/host/sdhci-pci.c
+++ b/drivers/mmc/host/sdhci-pci.c
@@ -1470,9 +1470,6 @@ static int sdhci_pci_probe(struct pci_dev *pdev,

slots = PCI_SLOT_INFO_SLOTS(slots) + 1;
dev_dbg(&pdev->dev, "found %d slot(s)\n", slots);
- if (slots == 0)
- return -ENODEV;
-
BUG_ON(slots > MAX_SLOTS);

ret = pci_read_config_byte(pdev, PCI_SLOT_INFO, &first_bar);
--
1.8.1.2