LinuxLists.cc - [PATCH] dma: ipu: remove unnecessary platform_set

2013-08-21 09:52:59

Subject: [PATCH] dma: ipu: remove unnecessary platform_set_drvdata()

The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.

Signed-off-by: Jingoo Han <[email protected]>
---
drivers/dma/ipu/ipu_idmac.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/dma/ipu/ipu_idmac.c b/drivers/dma/ipu/ipu_idmac.c
index 608d4a2..cb9c0bc 100644
--- a/drivers/dma/ipu/ipu_idmac.c
+++ b/drivers/dma/ipu/ipu_idmac.c
@@ -1764,7 +1764,6 @@ static int ipu_remove(struct platform_device *pdev)
iounmap(ipu->reg_ic);
iounmap(ipu->reg_ipu);
tasklet_kill(&ipu->tasklet);
- platform_set_drvdata(pdev, NULL);

return 0;
}
--
1.7.10.4

2013-08-22 01:30:53

by Shawn Guo

[permalink] [raw]

Subject: Re: [PATCH] dma: ipu: remove unnecessary platform_set_drvdata()

On Wed, Aug 21, 2013 at 06:52:54PM +0900, Jingoo Han wrote:
> The driver core clears the driver data to NULL after device_release
> or on probe failure. Thus, it is not needed to manually clear the
> device driver data to NULL.
>
> Signed-off-by: Jingoo Han <[email protected]>

Acked-by: Shawn Guo <[email protected]>

> ---
> drivers/dma/ipu/ipu_idmac.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/dma/ipu/ipu_idmac.c b/drivers/dma/ipu/ipu_idmac.c
> index 608d4a2..cb9c0bc 100644
> --- a/drivers/dma/ipu/ipu_idmac.c
> +++ b/drivers/dma/ipu/ipu_idmac.c
> @@ -1764,7 +1764,6 @@ static int ipu_remove(struct platform_device *pdev)
> iounmap(ipu->reg_ic);
> iounmap(ipu->reg_ipu);
> tasklet_kill(&ipu->tasklet);
> - platform_set_drvdata(pdev, NULL);
>
> return 0;
> }
> --
> 1.7.10.4
>
>

2013-08-25 09:53:07

by Vinod Koul

[permalink] [raw]