2013-09-02 08:09:04

by Sachin Kamat

Subject: [PATCH 1/1] dma: imx-dma: Remove redundant NULL check

kfree on a NULL pointer is a no-op. Null pointer check is
not necessary.

Signed-off-by: Sachin Kamat <[email protected]>
Cc: Sascha Hauer <[email protected]>
---
drivers/dma/imx-dma.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/dma/imx-dma.c b/drivers/dma/imx-dma.c
index ff2aab9..78f8ca5 100644
--- a/drivers/dma/imx-dma.c
+++ b/drivers/dma/imx-dma.c
@@ -805,10 +805,8 @@ static void imxdma_free_chan_resources(struct dma_chan *chan)
}
INIT_LIST_HEAD(&imxdmac->ld_free);

- if (imxdmac->sg_list) {
- kfree(imxdmac->sg_list);
- imxdmac->sg_list = NULL;
- }
+ kfree(imxdmac->sg_list);
+ imxdmac->sg_list = NULL;
}

static struct dma_async_tx_descriptor *imxdma_prep_slave_sg(
--
1.7.9.5

2013-09-02 08:19:20

by Sascha Hauer

Subject: Re: [PATCH 1/1] dma: imx-dma: Remove redundant NULL check

On Mon, Sep 02, 2013 at 01:21:18PM +0530, Sachin Kamat wrote:
> kfree on a NULL pointer is a no-op. Null pointer check is
> not necessary.
>
> Signed-off-by: Sachin Kamat <[email protected]>
> Cc: Sascha Hauer <[email protected]>

Acked-by: Sascha Hauer <[email protected]>

Sascha

> ---
> drivers/dma/imx-dma.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/dma/imx-dma.c b/drivers/dma/imx-dma.c
> index ff2aab9..78f8ca5 100644
> --- a/drivers/dma/imx-dma.c
> +++ b/drivers/dma/imx-dma.c
> @@ -805,10 +805,8 @@ static void imxdma_free_chan_resources(struct dma_chan *chan)
> }
> INIT_LIST_HEAD(&imxdmac->ld_free);
>
> - if (imxdmac->sg_list) {
> - kfree(imxdmac->sg_list);
> - imxdmac->sg_list = NULL;
> - }
> + kfree(imxdmac->sg_list);
> + imxdmac->sg_list = NULL;
> }
>
> static struct dma_async_tx_descriptor *imxdma_prep_slave_sg(
> --
> 1.7.9.5
>
>

--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |

2013-09-02 11:32:36

by Vinod Koul

Subject: Re: [PATCH 1/1] dma: imx-dma: Remove redundant NULL check

On Mon, Sep 02, 2013 at 01:21:18PM +0530, Sachin Kamat wrote:
> kfree on a NULL pointer is a no-op. Null pointer check is
> not necessary.

Applied, thanks

~Vinod