2013-09-04 14:40:35

by Michal Simek

[permalink] [raw]
Subject: [PATCH] dma: pl330: Simplify irq allocation


Attachments:
(No filename) (1.37 kB)
(No filename) (198.00 B)
Download all attachments

2013-09-12 14:30:24

by Vinod Koul

[permalink] [raw]
Subject: Re: [PATCH] dma: pl330: Simplify irq allocation

On Wed, Sep 04, 2013 at 04:40:17PM +0200, Michal Simek wrote:
> Use devm_request_irq function.

Applied, thanks

~Vinod


Attachments:
(No filename) (120.00 B)
signature.asc (836.00 B)
Digital signature
Download all attachments

2013-09-13 09:33:37

by Michal Simek

[permalink] [raw]
Subject: Re: [PATCH] dma: pl330: Simplify irq allocation

On 09/12/2013 03:42 PM, Vinod Koul wrote:
> On Wed, Sep 04, 2013 at 04:40:17PM +0200, Michal Simek wrote:
>> Use devm_request_irq function.
>
> Applied, thanks

Thanks. I have one change in my tree which I would like to get to the mainline
but it will need more interaction with others pl330 users.
It is about adding support for interrupt per channel feature.
For our case we have 8 channels and every channel has specific interrupt
+ we have one abort IRQ.

Based on the binding and Linux code two changes are necessary.
1. Extend AMBA_NR_IRQS because we have 9 IRQs
2. Driver change which is just register irqs when they are available.

Are these two changes OK for you?

Thanks,
Michal


--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: http://www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform



Attachments:
signature.asc (263.00 B)
OpenPGP digital signature

2013-09-17 07:56:20

by Vinod Koul

[permalink] [raw]
Subject: Re: [PATCH] dma: pl330: Simplify irq allocation

On Fri, Sep 13, 2013 at 11:33:33AM +0200, Michal Simek wrote:
> On 09/12/2013 03:42 PM, Vinod Koul wrote:
> > On Wed, Sep 04, 2013 at 04:40:17PM +0200, Michal Simek wrote:
> >> Use devm_request_irq function.
> >
> > Applied, thanks
>
> Thanks. I have one change in my tree which I would like to get to the mainline
> but it will need more interaction with others pl330 users.
> It is about adding support for interrupt per channel feature.
> For our case we have 8 channels and every channel has specific interrupt
> + we have one abort IRQ.
>
> Based on the binding and Linux code two changes are necessary.
> 1. Extend AMBA_NR_IRQS because we have 9 IRQs
> 2. Driver change which is just register irqs when they are available.
>
> Are these two changes OK for you?
Sure lets review them.

~Vinod
--


Attachments:
(No filename) (806.00 B)
signature.asc (836.00 B)
Digital signature
Download all attachments