2002-10-22 01:37:06

by Frank Davis

Subject: 2.5.44 : remove STATIC static ?

Hello all,
The following files contain:

#define STATIC static

arch/arm/boot/compressed/misc.c
arch/cris/boot/compressed/misc.c
arch/i386/boot/compressed/misc.c
arch/sh/boot/compressed/misc.c
arch/x86_64/boot/compressed/misc.c
drivers/net/irda/donauboe.c
drivers/scsi/53c700.c
drivers/scsi/NCR_D700.c
drivers/scsi/advansys.c
fs/xfs/linux/xfs_linux.h
init/do_mounts.c

Is this macro really needed (for some reason that escapes me), or can we
remove this macro? It seems to serve as to 'hide' a common keyword.

Regards,
Frank

2002-10-22 09:24:11

by Alan

Subject: Re: 2.5.44 : remove STATIC static ?

On Tue, 2002-10-22 at 02:35, Frank Davis wrote:
> drivers/scsi/53c700.c
> drivers/scsi/NCR_D700.c
> drivers/scsi/advansys.c
> fs/xfs/linux/xfs_linux.h
> init/do_mounts.c
>
> Is this macro really needed (for some reason that escapes me), or can we
> remove this macro? It seems to serve as to 'hide' a common keyword.

Some people used to use it so get debugger visible symbols for static
variables when debugging code. That era has gone.