2013-10-15 13:07:20

by Enrico Mioso

[permalink] [raw]
Subject: [PATCH] usb: serial: option: blacklist Olivetti Olicard200

Interface 6 of this device speaks QMI as per tests done by us.
Credits go to Antonella for providing the hardware.

Signed-off-by: Enrico Mioso <[email protected]>
Signed-off-by: Antonella Pellizzari <[email protected]>

diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
index 80a7104..d7c10d6 100644
--- a/drivers/usb/serial/option.c
+++ b/drivers/usb/serial/option.c
@@ -1257,7 +1257,9 @@ static const struct usb_device_id option_ids[] = {

{ USB_DEVICE(OLIVETTI_VENDOR_ID, OLIVETTI_PRODUCT_OLICARD100) },
{ USB_DEVICE(OLIVETTI_VENDOR_ID, OLIVETTI_PRODUCT_OLICARD145) },
- { USB_DEVICE(OLIVETTI_VENDOR_ID, OLIVETTI_PRODUCT_OLICARD200) },
+ { USB_DEVICE(OLIVETTI_VENDOR_ID, OLIVETTI_PRODUCT_OLICARD200),
+ .driver_info = (kernel_ulong_t)&net_intf6_blacklist
+ },
{ USB_DEVICE(CELOT_VENDOR_ID, CELOT_PRODUCT_CT680M) }, /* CT-650 CDMA 450 1xEVDO modem */
{ USB_DEVICE_AND_INTERFACE_INFO(SAMSUNG_VENDOR_ID, SAMSUNG_PRODUCT_GT_B3730, USB_CLASS_CDC_DATA, 0x00, 0x00) }, /* Samsung GT-B3730 LTE USB modem.*/
{ USB_DEVICE(YUGA_VENDOR_ID, YUGA_PRODUCT_CEM600) },
--
1.8.4


2013-10-15 13:07:22

by Enrico Mioso

[permalink] [raw]
Subject: [PATCH] net: qmi_wwan: Olivetti Olicard 200 support

This is a QMI device, manufactured by TCT Mobile Phones.
A companion patch blacklisting this device's QMI interface in the option.c
driver has been sent.

Signed-off-by: Enrico Mioso <[email protected]>
Signed-off-by: Antonella Pellizzari <[email protected]>

diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
index 3d6aaf7..818ce90 100644
--- a/drivers/net/usb/qmi_wwan.c
+++ b/drivers/net/usb/qmi_wwan.c
@@ -714,6 +714,7 @@ static const struct usb_device_id products[] = {
{QMI_FIXED_INTF(0x2357, 0x0201, 4)}, /* TP-LINK HSUPA Modem MA180 */
{QMI_FIXED_INTF(0x2357, 0x9000, 4)}, /* TP-LINK MA260 */
{QMI_FIXED_INTF(0x1bc7, 0x1200, 5)}, /* Telit LE920 */
+ {QMI_FIXED_INTF(0x0b3c, 0xc005, 6)}, /* Olivetti Olicard 200 */
{QMI_FIXED_INTF(0x1e2d, 0x0060, 4)}, /* Cinterion PLxx */

/* 4. Gobi 1000 devices */
--
1.8.4

2013-10-15 14:42:07

by Dan Williams

[permalink] [raw]
Subject: Re: [PATCH] usb: serial: option: blacklist Olivetti Olicard200

On Tue, 2013-10-15 at 15:06 +0200, Enrico Mioso wrote:
> Interface 6 of this device speaks QMI as per tests done by us.
> Credits go to Antonella for providing the hardware.
>
> Signed-off-by: Enrico Mioso <[email protected]>
> Signed-off-by: Antonella Pellizzari <[email protected]>

Tested-by: Dan Williams <[email protected]>

> diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
> index 80a7104..d7c10d6 100644
> --- a/drivers/usb/serial/option.c
> +++ b/drivers/usb/serial/option.c
> @@ -1257,7 +1257,9 @@ static const struct usb_device_id option_ids[] = {
>
> { USB_DEVICE(OLIVETTI_VENDOR_ID, OLIVETTI_PRODUCT_OLICARD100) },
> { USB_DEVICE(OLIVETTI_VENDOR_ID, OLIVETTI_PRODUCT_OLICARD145) },
> - { USB_DEVICE(OLIVETTI_VENDOR_ID, OLIVETTI_PRODUCT_OLICARD200) },
> + { USB_DEVICE(OLIVETTI_VENDOR_ID, OLIVETTI_PRODUCT_OLICARD200),
> + .driver_info = (kernel_ulong_t)&net_intf6_blacklist
> + },
> { USB_DEVICE(CELOT_VENDOR_ID, CELOT_PRODUCT_CT680M) }, /* CT-650 CDMA 450 1xEVDO modem */
> { USB_DEVICE_AND_INTERFACE_INFO(SAMSUNG_VENDOR_ID, SAMSUNG_PRODUCT_GT_B3730, USB_CLASS_CDC_DATA, 0x00, 0x00) }, /* Samsung GT-B3730 LTE USB modem.*/
> { USB_DEVICE(YUGA_VENDOR_ID, YUGA_PRODUCT_CEM600) },

2013-10-15 14:44:40

by Dan Williams

[permalink] [raw]
Subject: Re: [PATCH] net: qmi_wwan: Olivetti Olicard 200 support

On Tue, 2013-10-15 at 15:06 +0200, Enrico Mioso wrote:
> This is a QMI device, manufactured by TCT Mobile Phones.
> A companion patch blacklisting this device's QMI interface in the option.c
> driver has been sent.
>
> Signed-off-by: Enrico Mioso <[email protected]>
> Signed-off-by: Antonella Pellizzari <[email protected]>

Good find. For the record, mine has:

PX1522E16X 1 [Oct 15 2010 02:00:00]

ctl (1.4)
wds (1.8)
dms (1.3)
nas (1.2)
qos (1.2)
wms (1.1)
pds (1.4)
auth (1.0)
voice (1.0)
cat2 (1.1)

Tested-by: Dan Williams <[email protected]>

> diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
> index 3d6aaf7..818ce90 100644
> --- a/drivers/net/usb/qmi_wwan.c
> +++ b/drivers/net/usb/qmi_wwan.c
> @@ -714,6 +714,7 @@ static const struct usb_device_id products[] = {
> {QMI_FIXED_INTF(0x2357, 0x0201, 4)}, /* TP-LINK HSUPA Modem MA180 */
> {QMI_FIXED_INTF(0x2357, 0x9000, 4)}, /* TP-LINK MA260 */
> {QMI_FIXED_INTF(0x1bc7, 0x1200, 5)}, /* Telit LE920 */
> + {QMI_FIXED_INTF(0x0b3c, 0xc005, 6)}, /* Olivetti Olicard 200 */
> {QMI_FIXED_INTF(0x1e2d, 0x0060, 4)}, /* Cinterion PLxx */
>
> /* 4. Gobi 1000 devices */

2013-10-15 16:07:58

by Enrico Mioso

[permalink] [raw]
Subject: Re: [PATCH] net: qmi_wwan: Olivetti Olicard 200 support

:) I'm very happy you got it working.
The firmware of our device seems so fragile still - and several QMI calls can
bring it to a crashing state, especially when asking a network scan to the NAS
service.


On Tue, 15 Oct 2013, Dan Williams wrote:

==Date: Tue, 15 Oct 2013 09:49:57 -0500
==From: Dan Williams <[email protected]>
==To: Enrico Mioso <[email protected]>
==Cc: [email protected], [email protected], [email protected],
== [email protected], [email protected],
== [email protected], [email protected],
== Antonella Pellizzari <[email protected]>
==Subject: Re: [PATCH] net: qmi_wwan: Olivetti Olicard 200 support
==
==On Tue, 2013-10-15 at 15:06 +0200, Enrico Mioso wrote:
==> This is a QMI device, manufactured by TCT Mobile Phones.
==> A companion patch blacklisting this device's QMI interface in the option.c
==> driver has been sent.
==>
==> Signed-off-by: Enrico Mioso <[email protected]>
==> Signed-off-by: Antonella Pellizzari <[email protected]>
==
==Good find. For the record, mine has:
==
==PX1522E16X 1 [Oct 15 2010 02:00:00]
==
== ctl (1.4)
== wds (1.8)
== dms (1.3)
== nas (1.2)
== qos (1.2)
== wms (1.1)
== pds (1.4)
== auth (1.0)
== voice (1.0)
== cat2 (1.1)
==
==Tested-by: Dan Williams <[email protected]>
==
==> diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
==> index 3d6aaf7..818ce90 100644
==> --- a/drivers/net/usb/qmi_wwan.c
==> +++ b/drivers/net/usb/qmi_wwan.c
==> @@ -714,6 +714,7 @@ static const struct usb_device_id products[] = {
==> {QMI_FIXED_INTF(0x2357, 0x0201, 4)}, /* TP-LINK HSUPA Modem MA180 */
==> {QMI_FIXED_INTF(0x2357, 0x9000, 4)}, /* TP-LINK MA260 */
==> {QMI_FIXED_INTF(0x1bc7, 0x1200, 5)}, /* Telit LE920 */
==> + {QMI_FIXED_INTF(0x0b3c, 0xc005, 6)}, /* Olivetti Olicard 200 */
==> {QMI_FIXED_INTF(0x1e2d, 0x0060, 4)}, /* Cinterion PLxx */
==>
==> /* 4. Gobi 1000 devices */
==
==
==

2013-10-16 20:24:31

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH] net: qmi_wwan: Olivetti Olicard 200 support

On Tue, Oct 15, 2013 at 03:06:48PM +0200, Enrico Mioso wrote:
> This is a QMI device, manufactured by TCT Mobile Phones.
> A companion patch blacklisting this device's QMI interface in the option.c
> driver has been sent.
>
> Signed-off-by: Enrico Mioso <[email protected]>
> Signed-off-by: Antonella Pellizzari <[email protected]>

Acked-by: Greg Kroah-Hartman <[email protected]>

2013-10-17 20:01:26

by David Miller

[permalink] [raw]
Subject: Re: [PATCH] net: qmi_wwan: Olivetti Olicard 200 support

From: Enrico Mioso <[email protected]>
Date: Tue, 15 Oct 2013 15:06:48 +0200

> This is a QMI device, manufactured by TCT Mobile Phones.
> A companion patch blacklisting this device's QMI interface in the option.c
> driver has been sent.
>
> Signed-off-by: Enrico Mioso <[email protected]>
> Signed-off-by: Antonella Pellizzari <[email protected]>

Applied, thanks.