2014-01-23 09:06:32

by Lad, Prabhakar

[permalink] [raw]
Subject:

Hi Mark,

I see a issue with one of the davinci boards, where regulator_get() fails
from this patch "regulator: core: Provide a dummy regulator with full
constraints".
as I see regulator_get() supports dummy regulators by default.

So currently I am booting it traditional way (NON DT way) and
regulator_dev_lookup()
fails (return NULL) and for this check it fails.

+ if (ret && ret != -ENODEV) {
regulator = ERR_PTR(ret);
goto out;
}
In the NON-DT case the 'ret' is never updated in regulator_dev_lookup().

I tried adding regulator_has_full_constraints(); call in .init_machine
but results
the same. Any pointer would be helpfull.

Thanks,
--Prabhakar Lad


2014-01-23 19:56:00

by Mark Brown

[permalink] [raw]
Subject: Re: your mail

On Thu, Jan 23, 2014 at 02:36:05PM +0530, Prabhakar Lad wrote:
> Hi Mark,

Please use a subject line for your e-mails, otherwise they look a lot
like spam.

> So currently I am booting it traditional way (NON DT way) and
> regulator_dev_lookup()
> fails (return NULL) and for this check it fails.

> + if (ret && ret != -ENODEV) {
> regulator = ERR_PTR(ret);
> goto out;
> }
> In the NON-DT case the 'ret' is never updated in regulator_dev_lookup().

What is the problem you're trying to report here? You're describing the
behaviour of the code but I don't understand the problem.


Attachments:
(No filename) (609.00 B)
signature.asc (836.00 B)
Digital signature
Download all attachments