2002-11-01 10:10:27

by Adam J. Richter

[permalink] [raw]
Subject: Patch?: linux-2.5.45/net/ipv4/ dst.pmtu compilation fixes

linux-2.5.45 appears to have replaced dst_entry.pmtu with
dst_entry.metrics[RTAX_PMTU] and created a helper function
dst_pmtu(struct dst_entry*), presumably to simplify future changes
like this one. Here are patches to places in three files that were
apparently missed, preventing the files from compiling. Now the
files compile. That is as much as I have tested.

I am not currently familiar with this code, so I could easily
have misunderstood something in my patch.

I would appreciate it if the appropriate maintainer(s) would
examine this patch and forward it to Linus it seems OK. If there is
something else I should do, please let me know.

--
Adam J. Richter __ ______________ 575 Oroville Road
[email protected] \ / Milpitas, California 95035
+1 408 309-6081 | g g d r a s i l United States of America
"Free Software For The Rest Of Us."


Attachments:
(No filename) (922.00 B)
pmtu.diff (1.79 kB)
Download all attachments

2002-11-02 10:18:25

by David Miller

[permalink] [raw]
Subject: Re: Patch?: linux-2.5.45/net/ipv4/ dst.pmtu compilation fixes

On Fri, 2002-11-01 at 03:16, Adam J. Richter wrote:
> I am not currently familiar with this code, so I could easily
> have misunderstood something in my patch.

The only mistakes is that you cannot assign to
dst->metrics[RTAX_PMTU-1], you must use
dst->ops->update_mtu() instead.

I've made this change and installed the fixes to my
tree. Thanks.