2014-02-13 03:39:11

by Kuninori Morimoto

[permalink] [raw]
Subject: [PATCH] regulator: gpio: reborn necessary prop

From: Kuninori Morimoto <[email protected]>

934624d6e9f0b3d41557c4105c286e8daeaadb4e
(regulator: gpio-regulator: do not open-code counting and access of dt array elements)
removed struct property *prop from of_get_gpio_regulator_config()
but, it is still used on
0094050d783bbadffe83effef11a0bda901153ce
(regulator: gpio: add gpios-status for DT)

Compile will fail without this patch

gpio-regulator.c: In function 'of_get_gpio_regulator_config':
gpio-regulator.c:174:2: error: 'prop' undeclared (first use in this function)
gpio-regulator.c:174:2: note: each undeclared identifier is reported \
only once for each function it appears in

Signed-off-by: Kuninori Morimoto <[email protected]>
---
This is for latest mark-regulator/topic/gpio branch

drivers/regulator/gpio-regulator.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/regulator/gpio-regulator.c b/drivers/regulator/gpio-regulator.c
index 9fd5561..20248c1 100644
--- a/drivers/regulator/gpio-regulator.c
+++ b/drivers/regulator/gpio-regulator.c
@@ -136,6 +136,7 @@ static struct gpio_regulator_config *
of_get_gpio_regulator_config(struct device *dev, struct device_node *np)
{
struct gpio_regulator_config *config;
+ struct property *prop;
const char *regtype;
int proplen, gpio, i;
int ret;
--
1.7.9.5


2014-02-13 19:03:11

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH] regulator: gpio: reborn necessary prop

On Wed, Feb 12, 2014 at 07:39:07PM -0800, Kuninori Morimoto wrote:
> From: Kuninori Morimoto <[email protected]>
>
> 934624d6e9f0b3d41557c4105c286e8daeaadb4e
> (regulator: gpio-regulator: do not open-code counting and access of dt array elements)
> removed struct property *prop from of_get_gpio_regulator_config()
> but, it is still used on
> 0094050d783bbadffe83effef11a0bda901153ce
> (regulator: gpio: add gpios-status for DT)

Applied, thanks.


Attachments:
(No filename) (464.00 B)
signature.asc (836.00 B)
Digital signature
Download all attachments