2014-02-19 22:14:04

by Stefan Seyfried

[permalink] [raw]
Subject: [PATCH] Makefile: fix syntax error in warning message

From: Stefan Seyfried <[email protected]>

---
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile b/Makefile
index 893d6f0..eeaf3e7 100644
--- a/Makefile
+++ b/Makefile
@@ -606,7 +606,7 @@ ifdef CONFIG_CC_STACKPROTECTOR_REGULAR
stackp-flag := -fstack-protector
ifeq ($(call cc-option, $(stackp-flag)),)
$(warning Cannot use CONFIG_CC_STACKPROTECTOR: \
- -fstack-protector not supported by compiler))
+ -fstack-protector not supported by compiler)
endif
else ifdef CONFIG_CC_STACKPROTECTOR_STRONG
stackp-flag := -fstack-protector-strong
--
1.8.5.2


Stefan Seyfried
Linux Consultant & Developer -- GPG Key: 0x731B665B

B1 Systems GmbH
Osterfeldstra├če 7 / 85088 Vohburg / http://www.b1-systems.de
GF: Ralph Dehner / Unternehmenssitz: Vohburg / AG: Ingolstadt,HRB 3537


2014-02-21 00:14:03

by Kees Cook

[permalink] [raw]
Subject: Re: [PATCH] Makefile: fix syntax error in warning message

On Wed, Feb 19, 2014 at 2:13 PM, <[email protected]> wrote:
> From: Stefan Seyfried <[email protected]>
>
> ---
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index 893d6f0..eeaf3e7 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -606,7 +606,7 @@ ifdef CONFIG_CC_STACKPROTECTOR_REGULAR
> stackp-flag := -fstack-protector
> ifeq ($(call cc-option, $(stackp-flag)),)
> $(warning Cannot use CONFIG_CC_STACKPROTECTOR: \
> - -fstack-protector not supported by compiler))
> + -fstack-protector not supported by compiler)
> endif
> else ifdef CONFIG_CC_STACKPROTECTOR_STRONG
> stackp-flag := -fstack-protector-strong

Hi!

Thanks, yes, this has already been picked up:
http://marc.info/?l=linux-mm-commits&m=139275774732494&w=2

-Kees

--
Kees Cook
Chrome OS Security