2014-04-15 02:17:20

by Stephen Rothwell

[permalink] [raw]

Subject: linux-next: build failure after merge of the spi tree

---

Hi Mark,

After merging the spi tree, today's linux-next build (x86_64_allmodconfig)
failed like this:

drivers/spi/spi-cadence.c: In function 'cdns_spi_write':
drivers/spi/spi-cadence.c:135:2: error: implicit declaration of function 'writel_relaxed' [-Werror=implicit-function-declaration]
writel_relaxed(val, xspi->regs + offset);
^

Caused by commit c474b3866546 ("spi: Add driver for Cadence SPI controller").

I have used the spi tree from next-20140414 for today.

--
Cheers,
Stephen Rothwell [email protected]

---

Attachments:

(No filename) (544.00 B)
(No filename) (836.00 B)
Download all attachments

2014-04-15 04:36:05

by Harini Katakam

[permalink] [raw]

Subject: RE: linux-next: build failure after merge of the spi tree

---

Hi Stephen/Mark,

> -----Original Message-----
> From: Stephen Rothwell [mailto:[email protected]]
> Sent: Tuesday, April 15, 2014 7:47 AM
> To: Mark Brown
> Cc: [email protected]; [email protected]; Harini
> Katakam
> Subject: linux-next: build failure after merge of the spi tree
>
> Hi Mark,
>
> After merging the spi tree, today's linux-next build (x86_64_allmodconfig)
> failed like this:
>
> drivers/spi/spi-cadence.c: In function 'cdns_spi_write':
> drivers/spi/spi-cadence.c:135:2: error: implicit declaration of function
> 'writel_relaxed' [-Werror=implicit-function-declaration]
> writel_relaxed(val, xspi->regs + offset);
> ^
>

I'm sorry - I just noticed that Soren's patches for I2C also gave a similar warning:
http://patchwork.ozlabs.org/patch/337285/

I will send a patch adding dependency on ARCH_ZYNQ.
Please let me know if you have a better suggestion.

Regards,
Harini