2014-04-15 20:35:04

by Rob Herring

[permalink] [raw]
Subject: Re: [RFC PATCH 0/4] vmlinux.lds.h clean-ups

On Thu, Mar 27, 2014 at 2:41 PM, Rob Herring <[email protected]> wrote:
> From: Rob Herring <[email protected]>
>
> Several DeviceTree related sections have been added recently to enable
> early DT initialization calls. I have the need to add yet another one
> in order to do a DT based earlycon. Since each section follows the same
> pattern, this seemed like a good opportunity for some clean-up. So
> this series creates a common macro to define these sections. with this
> adding any new OF table section is a 2 line change.
>
> Each section ends with a zeroed struct of_device_id (except cpu_method).
> Right now there is an end section and a dummy variable to create the end
> marker. Really, we just need padding here, but I haven't come up with a
> way for the linker script to get the struct size.
>
> The last patch extends the same concept to another common pattern for
> section definitons. There's still others which could be easily converted
> also, but I'm looking for feedback on this approach before proceeding
> any further.
>
> Rob
>
> Rob Herring (4):
> irqchip: align irqchip OF match table section naming
> ARM: align cpu_method_of_table naming
> vmlinuz.lds: define OF table sections with macros
> vmlinux.lds: define conditional sections with macros
>
> arch/arm/kernel/devtree.c | 11 +--
> drivers/irqchip/irqchip.c | 6 +-
> include/asm-generic/vmlinux.lds.h | 142 +++++++++++---------------------------

Arnd, Any comments on this series?

Rob


2014-04-24 13:23:10

by Arnd Bergmann

[permalink] [raw]
Subject: Re: [RFC PATCH 0/4] vmlinux.lds.h clean-ups

On Tuesday 15 April 2014, Rob Herring wrote:
> >
> > arch/arm/kernel/devtree.c | 11 +--
> > drivers/irqchip/irqchip.c | 6 +-
> > include/asm-generic/vmlinux.lds.h | 142 +++++++++++---------------------------
>
> Arnd, Any comments on this series?
>

No qualified comments. The linker script is always magic to me. For all I can
tell, it's all good and you can add an Acked-by from me if that helps you,
but I'm not able to judge whether it's correct. Do you want to merge it
through the DT git?

Arnd