2014-06-18 04:50:01

by Andy Gross

Subject: [PATCH] pinctrl: qcom: Add BUS_HOLD pin bias

This patch adds the BUS_HOLD (Keeper) bias option for pins.

Signed-off-by: Andy Gross <[email protected]>
---
drivers/pinctrl/pinctrl-msm.c | 8 ++++++++
1 file changed, 8 insertions(+)

diff --git a/drivers/pinctrl/pinctrl-msm.c b/drivers/pinctrl/pinctrl-msm.c
index e43fbce..9aa2839 100644
--- a/drivers/pinctrl/pinctrl-msm.c
+++ b/drivers/pinctrl/pinctrl-msm.c
@@ -206,6 +206,7 @@ static int msm_config_reg(struct msm_pinctrl *pctrl,
switch (param) {
case PIN_CONFIG_BIAS_DISABLE:
case PIN_CONFIG_BIAS_PULL_DOWN:
+ case PIN_CONFIG_BIAS_BUS_HOLD:
case PIN_CONFIG_BIAS_PULL_UP:
*bit = g->pull_bit;
*mask = 3;
@@ -243,6 +244,7 @@ static int msm_config_set(struct pinctrl_dev *pctldev, unsigned int pin,

#define MSM_NO_PULL 0
#define MSM_PULL_DOWN 1
+#define MSM_KEEPER 2
#define MSM_PULL_UP 3

static unsigned msm_regval_to_drive(u32 val)
@@ -280,6 +282,9 @@ static int msm_config_group_get(struct pinctrl_dev *pctldev,
case PIN_CONFIG_BIAS_PULL_DOWN:
arg = arg == MSM_PULL_DOWN;
break;
+ case PIN_CONFIG_BIAS_BUS_HOLD:
+ arg = arg == MSM_KEEPER;
+ break;
case PIN_CONFIG_BIAS_PULL_UP:
arg = arg == MSM_PULL_UP;
break;
@@ -339,6 +344,9 @@ static int msm_config_group_set(struct pinctrl_dev *pctldev,
case PIN_CONFIG_BIAS_PULL_DOWN:
arg = MSM_PULL_DOWN;
break;
+ case PIN_CONFIG_BIAS_BUS_HOLD:
+ arg = MSM_KEEPER;
+ break;
case PIN_CONFIG_BIAS_PULL_UP:
arg = MSM_PULL_UP;
break;
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation

2014-06-18 05:22:53

by Bjorn Andersson

Subject: Re: [PATCH] pinctrl: qcom: Add BUS_HOLD pin bias

On Tue, Jun 17, 2014 at 9:49 PM, Andy Gross <[email protected]> wrote:
> This patch adds the BUS_HOLD (Keeper) bias option for pins.
>
> Signed-off-by: Andy Gross <[email protected]>

Acked-by: Bjorn Andersson <[email protected]>

2014-07-07 14:21:46

by Linus Walleij

Subject: Re: [PATCH] pinctrl: qcom: Add BUS_HOLD pin bias

On Wed, Jun 18, 2014 at 6:49 AM, Andy Gross <[email protected]> wrote:

> This patch adds the BUS_HOLD (Keeper) bias option for pins.
>
> Signed-off-by: Andy Gross <[email protected]>

Patch applied with Björn's ACK, thanks Andy.

Yours,
Linus Walleij