2014-07-04 21:08:09

by Davidlohr Bueso

Subject: [PATCH] mm,vmacache: inline vmacache_valid_mm()

From: Davidlohr Bueso <[email protected]>

No brainer for this little function.

Signed-off-by: Davidlohr Bueso <[email protected]>
---
mm/vmacache.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/vmacache.c b/mm/vmacache.c
index 9f25af8..e72b8ee 100644
--- a/mm/vmacache.c
+++ b/mm/vmacache.c
@@ -50,7 +50,7 @@ void vmacache_flush_all(struct mm_struct *mm)
* Also handle the case where a kernel thread has adopted this mm via use_mm().
* That kernel thread's vmacache is not applicable to this mm.
*/
-static bool vmacache_valid_mm(struct mm_struct *mm)
+static inline bool vmacache_valid_mm(struct mm_struct *mm)
{
return current->mm == mm && !(current->flags & PF_KTHREAD);
}
--
1.8.1.4

2014-07-07 22:07:59

by Andrew Morton

Subject: Re: [PATCH] mm,vmacache: inline vmacache_valid_mm()

On Fri, 04 Jul 2014 14:08:03 -0700 Davidlohr Bueso <[email protected]> wrote:

> From: Davidlohr Bueso <[email protected]>
>
> No brainer for this little function.
>
> ...
>
> --- a/mm/vmacache.c
> +++ b/mm/vmacache.c
> @@ -50,7 +50,7 @@ void vmacache_flush_all(struct mm_struct *mm)
> * Also handle the case where a kernel thread has adopted this mm via use_mm().
> * That kernel thread's vmacache is not applicable to this mm.
> */
> -static bool vmacache_valid_mm(struct mm_struct *mm)
> +static inline bool vmacache_valid_mm(struct mm_struct *mm)
> {
> return current->mm == mm && !(current->flags & PF_KTHREAD);
> }

The patch doesn't actually do anything.

- gcc ignores `inline'

- gcc will inline this function anwyay

- if we really really need a hammer, we use __always_inline, along
with a comment explaining why.